--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 30B42431FAF\r
+ for <notmuch@notmuchmail.org>; Thu, 2 Aug 2012 00:19:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id sQcFunOa+TPZ for <notmuch@notmuchmail.org>;\r
+ Thu, 2 Aug 2012 00:19:44 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 881F7431FAE\r
+ for <notmuch@notmuchmail.org>; Thu, 2 Aug 2012 00:19:44 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Swph4-0004Fs-Da; Thu, 02 Aug 2012 08:19:38 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Swph4-0001co-3t; Thu, 02 Aug 2012 08:19:38 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, Austin Clements <amdragon@MIT.EDU>,\r
+ notmuch@notmuchmail.org\r
+Subject: [PATCH] emacs: fix a bug introduced by the recent search cleanups.\r
+In-Reply-To: <87mx2dais8.fsf@nikula.org>\r
+References: <1341354059-29396-1-git-send-email-amdragon@mit.edu>\r
+ <1342892232-5659-1-git-send-email-amdragon@mit.edu>\r
+ <1342892232-5659-8-git-send-email-amdragon@mit.edu>\r
+ <87mx2dais8.fsf@nikula.org>\r
+User-Agent: Notmuch/0.13.2+96~g634443c (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Thu, 02 Aug 2012 08:19:37 +0100\r
+Message-ID: <87r4rpsquu.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: be0b14068fdfc05b5b6d6afd87513faf (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 02 Aug 2012 07:19:45 -0000\r
+\r
+\r
+In commit 5d0883e the function notmuch-search-next-thread was changed.\r
+In particular it only goes to the next message if there is a next\r
+message. This breaks notmuch-show-archive-thread-then-next. Fix this\r
+by going to the "next" message whenever we are on a current message.\r
+---\r
+\r
+> On Sat, 21 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+>> At this point, the only remaining functions that don't support\r
+>> multi-line search result formats are the thread navigation functions.\r
+>> This patch fixes that by rewriting them in terms of\r
+>> notmuch-search-result-{beginning,end}.\r
+>>\r
+>> This changes the behavior of notmuch-search-previous-thread slightly\r
+>> so that if point isn't at the beginning of a result, it first moves\r
+>> point to the beginning of the result.\r
+>\r
+> Hi Austin, bisecting suggests this patch (committed as 5d0883e) breaks\r
+> notmuch-show-archive-thread-then-next and subsequently\r
+> notmuch-show-advance-and-archive for me. When showing the last thread in\r
+> the search results, notmuch-show-archive-thread-then-next used to exit\r
+> to the end of the search buffer. Now it redisplays the current\r
+> thread. When I hit SPC to cruise through mails, there's no indication\r
+> that I've reached the end of search results, other than the same thread\r
+> being displayed over and over.\r
+\r
+This might be the correct fix but I am not certain. It doesn't instantly\r
+break for me! (It looks more similar to what happened before the parent\r
+patch.)\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+ emacs/notmuch.el | 2 +-\r
+ 1 files changed, 1 insertions(+), 1 deletions(-)\r
+\r
+diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+index fd1836f..d2d82a9 100644\r
+--- a/emacs/notmuch.el\r
++++ b/emacs/notmuch.el\r
+@@ -293,7 +293,7 @@ For a mouse binding, return nil."\r
+ (defun notmuch-search-next-thread ()\r
+ "Select the next thread in the search results."\r
+ (interactive)\r
+- (when (notmuch-search-get-result (notmuch-search-result-end))\r
++ (when (notmuch-search-get-result)\r
+ (goto-char (notmuch-search-result-end))))\r
+ \r
+ (defun notmuch-search-previous-thread ()\r
+-- \r
+1.7.9.1\r
+\r
+\r
+\r
projects / notmuch-archives.git / commitdiff