Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close

diff --git a/be/456d2856817455caa778ae4ae5f61d199bdd65 b/be/456d2856817455caa778ae4ae5f61d199bdd65
new file mode 100644 (file)
index 0000000..8942ea9
--- /dev/null
+++ b/be/456d2856817455caa778ae4ae5f61d199bdd65
@@ -0,0 +1,87 @@
+Return-Path: <teythoon@jade-hamburg.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 81FF7431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Apr 2012 05:49:54 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id OiSBkHGbmfhc for <notmuch@notmuchmail.org>;\r
+       Mon, 23 Apr 2012 05:49:54 -0700 (PDT)\r
+Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D6073431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Apr 2012 05:49:53 -0700 (PDT)\r
+Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by mail.cryptobitch.de (Postfix) with ESMTPSA id 08CFA583DDE\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Apr 2012 14:49:52 +0200 (CEST)\r
+Received: by mail.jade-hamburg.de (Postfix, from userid 401)\r
+       id 4173ADF2A3; Mon, 23 Apr 2012 14:49:51 +0200 (CEST)\r
+Received: from thinkbox.jade-hamburg.de (unknown [193.174.12.196])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested) (Authenticated sender: teythoon)\r
+       by mail.jade-hamburg.de (Postfix) with ESMTPSA id 3F575DF2A0;\r
+       Mon, 23 Apr 2012 14:49:50 +0200 (CEST)\r
+Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77)\r
+       (envelope-from <teythoon@thinkbox.jade-hamburg.de>)\r
+       id 1SMIiB-0002Qo-1q; Mon, 23 Apr 2012 14:49:47 +0200\r
+Content-Type: text/plain; charset="utf-8"\r
+MIME-Version: 1.0\r
+Content-Transfer-Encoding: quoted-printable\r
+To: Felipe Contreras <felipe.contreras@gmail.com>, \r
+From: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+In-Reply-To:\r
+ <CAMP44s0KHJz6AxUfRjEUk5heOEFVyT2NixpFNb5GZakXaoLAKw@mail.gmail.com>\r
+References: <20120422120620.26225.40778@thinkbox.jade-hamburg.de>\r
+       <1335096477-27537-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <1335096477-27537-6-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <CAMP44s0KHJz6AxUfRjEUk5heOEFVyT2NixpFNb5GZakXaoLAKw@mail.gmail.com>\r
+Message-ID: <20120423124946.31231.53523@thinkbox.jade-hamburg.de>\r
+User-Agent: alot/0.3+\r
+Subject: Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of\r
+       notmuch_database_close\r
+Date: Mon, 23 Apr 2012 14:49:46 +0200\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 23 Apr 2012 12:49:54 -0000\r
+\r
+Quoting Felipe Contreras (2012-04-23 14:36:33)\r
+> I don't think this is the right approach. If database_destroy truly\r
+> destroys the object, then we would want to do it only at garbage\r
+> collection, when it's not accessible any more. What if I want to\r
+> re-use the database from the Ruby code?\r
+> =\r
+\r
+> This would probably be better:\r
+> =\r
+\r
+>[...]\r
+\r
+You're probably right, I don't know the ruby bindings at all, I just\r
+wanted to preserve the old behavior. You are welcome to refine the\r
+ruby bindings later (or maintain them, I *believe* they are\r
+unmaintained, the last change was back in october 2011), but let's get\r
+this patch series in first.\r
+\r
+Cheers,\r
+Justus\r