Re: [PATCH 2/2] test: emacs: run list-processes after accept-process-output in emacs...

diff --git a/bd/7f57df89a179f1894409790c48211b9e01c3bd b/bd/7f57df89a179f1894409790c48211b9e01c3bd
new file mode 100644 (file)
index 0000000..b992f6c
--- /dev/null
+++ b/bd/7f57df89a179f1894409790c48211b9e01c3bd
@@ -0,0 +1,156 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id CBCA4431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 17 Aug 2012 11:55:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id CqPg6kmHNjK4 for <notmuch@notmuchmail.org>;\r
+       Fri, 17 Aug 2012 11:55:06 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
+       [18.9.25.13])\r
+       by olra.theworths.org (Postfix) with ESMTP id 28F0F431FAF\r
+       for <notmuch@notmuchmail.org>; Fri, 17 Aug 2012 11:55:06 -0700 (PDT)\r
+X-AuditID: 1209190d-b7fd56d000000933-64-502e9387e696\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+       by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id FA.BC.02355.7839E205; Fri, 17 Aug 2012 14:55:03 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q7HIt2se013183; \r
+       Fri, 17 Aug 2012 14:55:03 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q7HIt16J014141\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Fri, 17 Aug 2012 14:55:02 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1T2RhF-0007PJ-0x; Fri, 17 Aug 2012 14:55:01 -0400\r
+Date: Fri, 17 Aug 2012 14:55:00 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 2/2] test: emacs: run list-processes after\r
+       accept-process-output in emacs 23.1\r
+Message-ID: <20120817185500.GP11179@mit.edu>\r
+References: <1344165182-29246-1-git-send-email-tomi.ollila@iki.fi>\r
+       <1344165182-29246-2-git-send-email-tomi.ollila@iki.fi>\r
+       <20120813151613.GN11179@mit.edu>\r
+       <m27gsz2se2.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <m27gsz2se2.fsf@guru.guru-group.fi>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmplleLIzCtJLcpLzFFi42IRYrdT122frBdg8P+qtcX1mzOZLd6snMfq\r
+       wORx+OtCFo9nq24xBzBFcdmkpOZklqUW6dslcGXcm3OSqaBPvGLvxo0sDYwzhboYOTkkBEwk\r
+       1u5+yQJhi0lcuLeerYuRi0NIYB+jROuen0wQzgZGiQ2Ni9khnJNMEvtWnWKFcJYwSmy78Ays\r
+       n0VAVeLc0b9gNpuAhsS2/csZQWwRARWJB23rWUFsZgFpiW+/m5lAbGGBFIn+9hlgcV4BHYn9\r
+       fesYIYYeYZQ4cPsjI0RCUOLkzCcsEM1aEjf+vQRq5gAbtPwfB0iYU8BA4sChPWDlokC7ppzc\r
+       xjaBUWgWku5ZSLpnIXQvYGRexSibklulm5uYmVOcmqxbnJyYl5dapGukl5tZopeaUrqJERTa\r
+       nJK8OxjfHVQ6xCjAwajEwzvZRzdAiDWxrLgy9xCjJAeTkihvXodegBBfUn5KZUZicUZ8UWlO\r
+       avEhRgkOZiURXieQHG9KYmVValE+TEqag0VJnPdKyk1/IYH0xJLU7NTUgtQimKwMB4eSBO/Z\r
+       SUCNgkWp6akVaZk5JQhpJg5OkOE8QMNPgNTwFhck5hZnpkPkTzEqSonzrgdJCIAkMkrz4Hph\r
+       qecVozjQK8K8S0GqeIBpC677FdBgJqDBK0V0QQaXJCKkpBoYzcW3dVxYnHTCU2xn8rKwhsCn\r
+       /zdVhiUqNXYuUGAIyre/WZDeIXjI4vhC/e7GhZf/v025eUmluTxfiOfm/WPLVBui9LRqu8/G\r
+       t4lN/ce0YuPBCRunRTXHT5/dVH87LmJu+1Ux//9l761zU48mWjBXdYfYGPRwFm6bxDKr+aPc\r
+       sqXNrbql3MpKLMUZiYZazEXFiQBi0b0OGAMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 17 Aug 2012 18:55:06 -0000\r
+\r
+Quoth Tomi Ollila on Aug 16 at 10:44 am:\r
+> On Mon, Aug 13 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> \r
+> > Quoth Tomi Ollila on Aug 05 at  2:13 pm:\r
+> >> When running emacs tests using emacs 23.1.1 the tests block (until timeout)\r
+> >> when emacs function (notmuch-test-wait) is called.\r
+> >> \r
+> >> There is an emacs bug #2930 titled:\r
+> >> 23.0.92; `accept-process-output' and `sleep-for' do not run sentinel\r
+> >> \r
+> >> It seems this is present in emacs 23.1.\r
+> >> \r
+> >> Calling list-processes after accept-process-output seems work around\r
+> >> this problem; in case Emacs version is 23.1 a defadvice is activated\r
+> >> to do just that.\r
+> >\r
+> > Should this workaround perhaps go in notmuch-test-wait directly,\r
+> > instead of being implemented as advice?  \r
+> \r
+> This way the fact that this is workaround for bug that exists only in\r
+> 23.1(*) is emphasized; The notmuch-test-wait can exist in a (simpler)\r
+> format where it doesn't need to know about this bug.\r
+\r
+Okay.\r
+\r
+> (*) This bug probably exists in emacs 22 but the MUA has not worked\r
+> on emacs 22 at least for a year now.\r
+> \r
+> > If we do want to keep it as advice, should it go in notmuch-lib.el\r
+> > along with the few other compatibility functions?\r
+> \r
+> In tests we have fixed environment where we can write workarounds\r
+> as "global" advices. If we did this in notmuch-lib.el we'd be changing\r
+> users' environment, possibly causing surprises...\r
+\r
+Oh, right, of course.  I'd forgotten that this was in test-lib.el and\r
+not in the general notmuch Emacs code.\r
+\r
+> ... but neither sleep-for or accept-process-output are used in \r
+> any of the notmuch elisp code so such "fixes" are not needed now...\r
+> \r
+> ... and this would ever be a problem, we might already support only\r
+> emacs 24 or newer >;) ...\r
+> \r
+> Tomi\r
+\r
+Series LGTM.\r
+\r
+> >> ---\r
+> >> \r
+> >> Thanks to Austin for the comments and IRC discussions on the matter.\r
+> >> \r
+> >>  test/test-lib.el |    8 ++++++++\r
+> >>  1 files changed, 8 insertions(+), 0 deletions(-)\r
+> >> \r
+> >> diff --git a/test/test-lib.el b/test/test-lib.el\r
+> >> index 52d9936..4330352 100644\r
+> >> --- a/test/test-lib.el\r
+> >> +++ b/test/test-lib.el\r
+> >> @@ -35,6 +35,16 @@\r
+> >>      "Disable yes-or-no-p before executing kill-emacs"\r
+> >>      (defun yes-or-no-p (prompt) t)))\r
+> >>  \r
+> >> +;; Emacs bug #2930:\r
+> >> +;;       23.0.92; `accept-process-output' and `sleep-for' do not run sentinels\r
+> >> +;; seems to be present in Emacs 23.1.\r
+> >> +;; Running `list-processes' after `accept-process-output' seems to work\r
+> >> +;; around this problem.\r
+> >> +(if (and (= emacs-major-version 23) (= emacs-minor-version 1))\r
+> >> +  (defadvice accept-process-output (after run-list-processes activate)\r
+> >> +    "run list-processes after executing accept-process-output"\r
+> >> +    (list-processes)))\r
+> >> +\r
+> >>  (defun notmuch-test-wait ()\r
+> >>    "Wait for process completion."\r
+> >>    (while (get-buffer-process (current-buffer))\r