Re: ‘class Xapian::Database’ has no member named ‘close’

diff --git a/30/0fa239dfaed5db7b2c8453a3f19c27b91c39d8 b/30/0fa239dfaed5db7b2c8453a3f19c27b91c39d8
new file mode 100644 (file)
index 0000000..b264b8c
--- /dev/null
+++ b/30/0fa239dfaed5db7b2c8453a3f19c27b91c39d8
@@ -0,0 +1,116 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0889C431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 14 Aug 2012 05:57:24 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id VQUuaCR1H7r6 for <notmuch@notmuchmail.org>;\r
+       Tue, 14 Aug 2012 05:57:23 -0700 (PDT)\r
+Received: from mail-gg0-f181.google.com (mail-gg0-f181.google.com\r
+       [209.85.161.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 69EC8431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 14 Aug 2012 05:57:23 -0700 (PDT)\r
+Received: by ggmb6 with SMTP id b6so510412ggm.26\r
+       for <notmuch@notmuchmail.org>; Tue, 14 Aug 2012 05:57:22 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type:content-transfer-encoding\r
+       :x-gm-message-state;\r
+       bh=DmAOBiBC7M46bZfRQHsCfRxICV9EQ/AIx2SzW3xgMns=;\r
+       b=hKkrh4mg6WgPhmPDF9SCaso64jSagnPjB88i59caCAUjd78ARG4A1OrU+0FkdH8ToN\r
+       u2U1FTCFK7NxeEYznSXbA/hgnyUdqghSbooqwSbUJQ8GcSLfTc5DoFWMqfpmdkX8m4Wv\r
+       /ZJfYllzyUL2Hgxdeg4FGDTwaJ04qB80WDDC0efuzRyDyMtUkRs6QZHXR89s+ZIFB4TQ\r
+       qTmzR0xtAIwVwD56/6usPJnTM34kYOQBh75CHT+PC9h3K65pj4rrOcM0Qrf8T7zjKY5H\r
+       WTm/nllb6fIcRMdCGtFEsQGgjaL2gXG588ZlDArnGlQB8g8v/ZrQx8ElsXQuXvirur47\r
+       k4XQ==\r
+Received: by 10.236.136.39 with SMTP id v27mr11549192yhi.96.1344949042587;\r
+       Tue, 14 Aug 2012 05:57:22 -0700 (PDT)\r
+Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3])\r
+       by mx.google.com with ESMTPS id c64sm4677778yhj.17.2012.08.14.05.57.18\r
+       (version=SSLv3 cipher=OTHER); Tue, 14 Aug 2012 05:57:21 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Michal Nazarewicz <mina86@mina86.com>, David Bremner <david@tethera.net>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: =?utf-8?Q?=E2=80=98class_Xapian=3A=3ADatabase=E2=80=99?= has no\r
+       member named =?utf-8?B?4oCYY2xvc2XigJk=?=\r
+In-Reply-To: <xa1tk3x1psm2.fsf@mina86.com>\r
+References: <xa1tsjbyd8v4.fsf@mina86.com>\r
+ <87a9xx4yuj.fsf@maritornes.cs.unb.ca> <xa1tk3x1psm2.fsf@mina86.com>\r
+User-Agent: Notmuch/0.13.2+131~gff9267e (http://notmuchmail.org) Emacs/23.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 14 Aug 2012 14:57:13 +0200\r
+Message-ID: <87fw7p1viu.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-Gm-Message-State:\r
+ ALoCoQmAWGn+8xlrRJGnxezmo7kwSxyZt7fZJdbI7HjuTDoeQKr9w2qwCs2HpDQKd6W3iGkg7wtD\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 14 Aug 2012 12:57:24 -0000\r
+\r
+On Tue, 14 Aug 2012, Michal Nazarewicz <mina86@mina86.com> wrote:\r
+> Yeah, it seems that INSTALL claims =E2=80=9CNotmuch will work best with X=\r
+apian\r
+> 1.0.18 (or later) or Xapian 1.1.4 (or later)=E2=80=9D, which doesn't seem=\r
+ to be\r
+> the case.\r
+>\r
+> On top of that, configure does not seem to even check the version\r
+> number.\r
+\r
+Someone(tm) should fix both of the above.\r
+\r
+> Is close() really required though?  The comment justifies it saying\r
+> that:\r
+>\r
+>      Many Xapian objects hold references to the database, so merely\r
+>      deleting the database may not suffice to close it.  Thus, we\r
+>      explicitly close it here.\r
+>\r
+> but wouldn't the database get closed when the last reference gets\r
+> deleted anyway?\r
+\r
+IIRC this was related to how closing is handled in the python\r
+bindings. The close was introduced in the commit below, not too long\r
+ago. I just reverted that one when I had to use notmuch with ancient\r
+xapian (but the usual disclaimers apply).\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+commit cfc5f1059aa16753cba610c41601cacc97260e08\r
+Author: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+Date:   Fri Mar 2 15:58:39 2012 +0100\r
+\r
+    Actually close the xapian database in notmuch_database_close\r
+=20=20=20=20\r
+    Formerly the xapian database object was deleted and closed in its\r
+    destructor once the object was garbage collected. Explicitly call\r
+    close() so that the database and the associated lock is released\r
+    immediately.\r
+=20=20=20=20\r
+    The comment is a courtesy of Austin Clements.\r
+=20=20=20=20\r
+    Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>\r