--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 1A1B5429E45\r
+ for <notmuch@notmuchmail.org>; Fri, 17 Feb 2012 19:32:33 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id oa7TMMj8Zx2e for <notmuch@notmuchmail.org>;\r
+ Fri, 17 Feb 2012 19:32:31 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
+ [18.9.25.13])\r
+ by olra.theworths.org (Postfix) with ESMTP id 59C3E431FAE\r
+ for <notmuch@notmuchmail.org>; Fri, 17 Feb 2012 19:32:31 -0800 (PST)\r
+X-AuditID: 1209190d-b7fbf6d0000008ba-29-4f3f1bcedf44\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+ by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 20.F0.02234.ECB1F3F4; Fri, 17 Feb 2012 22:32:30 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q1I3WU7I007962; \r
+ Fri, 17 Feb 2012 22:32:30 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q1I3WSOx018146\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Fri, 17 Feb 2012 22:32:29 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1Ryb0V-0004Cr-Cp; Fri, 17 Feb 2012 22:30:43 -0500\r
+Date: Fri, 17 Feb 2012 22:30:43 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>\r
+Subject: Re: [PATCH v5.2 7/7] emacs: Use the new JSON reply format and\r
+ message-cite-original\r
+Message-ID: <20120218033043.GJ5991@mit.edu>\r
+References: <1329361957-28493-1-git-send-email-awg+notmuch@xvx.ca>\r
+ <1329361957-28493-8-git-send-email-awg+notmuch@xvx.ca>\r
+ <20120217200017.GG5991@mit.edu>\r
+ <CAMoJFUs5jnu7=5PtrNib9J6P_FnxD8bK2L+oQiBdgXPJXhvMJg@mail.gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=iso-8859-1\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: 8bit\r
+In-Reply-To:\r
+ <CAMoJFUs5jnu7=5PtrNib9J6P_FnxD8bK2L+oQiBdgXPJXhvMJg@mail.gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFprLKsWRmVeSWpSXmKPExsUixCmqrXtO2t7f4HWjrcWRPbPYLa7fnMns\r
+ wOTxbNUtZo+mH4tZA5iiuGxSUnMyy1KL9O0SuDKeNF5gLJgoUrFh/RX2Bsb3/F2MnBwSAiYS\r
+ fw5MYoGwxSQu3FvP1sXIxSEksI9RYuKeHewQzgZGiZOvH0NlTjJJNBy9AZVZwigx6cBsdpB+\r
+ FgFVib+Nr1lBbDYBDYlt+5czgtgiAloSP9Z/BYszC0hLfPvdzARiCwvESXz7fgWsl1dAW+Lz\r
+ zclQQ58wSpzed5INIiEocXLmExaIZh2JnVvvAMU5wAYt/8cBEZaXaN46mxnE5hQIlNi/sR1s\r
+ r6iAisSUk9vYJjAKz0IyaRaSSbMQJs1CMmkBI8sqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXSO9\r
+ 3MwSvdSU0k2M4FiQ5N3B+O6g0iFGAQ5GJR5exx47fyHWxLLiytxDjJIcTEqivP1S9v5CfEn5\r
+ KZUZicUZ8UWlOanFhxglOJiVRHi97gCV86YkVlalFuXDpKQ5WJTEeVW13vkJCaQnlqRmp6YW\r
+ pBbBZGU4OJQkeMWBMS8kWJSanlqRlplTgpBm4uAEGc4DNHwHyGLe4oLE3OLMdIj8KUZFKXFe\r
+ ZpBmAZBERmkeXC8sVb1iFAd6RZj3A0g7DzDNwXW/AhrMBDSYVwjk6uKSRISUVAPjjceXkrZy\r
+ R9id+rlhhZjr2n8nGUXrdfhnhEUf3cvt+qqU496sXFmXCeXN0bck1Fcwqjrk3Fv5Y1fu05Pv\r
+ rZa9Yvr+d06d24S/3550WfwzeB0R63RdL/lxk5FKx+m4u9f+9rdO6ddRCku/7SfA4Bm4f2bi\r
+ nV0hX5/3pu3KOij2VzJ3nnremZCHSizFGYmGWsxFxYkAL5PORTADAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 18 Feb 2012 03:32:33 -0000\r
+\r
+Quoth Adam Wolfe Gordon on Feb 17 at 7:22 pm:\r
+> On Fri, Feb 17, 2012 at 13:00, Austin Clements <amdragon@mit.edu> wrote:\r
+> > One general comment that affects a lot of things in this patch: I\r
+> > think you should use the same JSON parsing settings that\r
+> > notmuch-query-get-threads uses. Besides consistency and more\r
+> > opportunities for code reuse, using lists instead of vectors for JSON\r
+> > arrays will simplify a lot of this code without any drawbacks.\r
+> \r
+> I pretty much agree. The only reason I stuck with alists was, as you\r
+> mention below, to be compatible with certain mail functions. Given the\r
+> things you've pointed out, I think the small hassle of making those\r
+> work with plists is worthwhile, so I'll give it a go.\r
+> \r
+> Clarification on a couple of things follow, otherwise I'll make all\r
+> these changes for the next version.\r
+> \r
+> >> + (goto-char (point-max)))\r
+> >> +\r
+> >> + (let ((from (cdr (assq 'From original-headers)))\r
+> >> + (date (cdr (assq 'Date original-headers)))\r
+> >> + (start (point)))\r
+> >> +\r
+> >> + (insert "From: " from "\n")\r
+> >> + (insert "Date: " date "\n\n")\r
+> >\r
+> > Sorry; I'm having trouble following the diff. What are the inserts\r
+> > for?\r
+> \r
+> The function message-cite-original cites an original message, which is\r
+> in the marked region. It assumes the headers of the original message\r
+> will be part of the marked region, but the only ones it actually uses\r
+> are From and Date.\r
+> \r
+> This could probably use a comment in the code.\r
+\r
+Ah, okay. Is this how it generates the citation line?\r
+\r
+Could definitely do with a comment.\r
+\r
+> >> + (push-mark)\r
+> >\r
+> > It's unfortunate that message-cite-original depends on the mark.\r
+> > Since you're about to push the mark for the user anyway, maybe this\r
+> > should be a set-mark so that only one mark gets pushed?\r
+> \r
+> Probably the right thing to do.\r
+> \r
+> >> + (goto-char start)\r
+> >> + ;; Quote the original message according to the user's configured style.\r
+> >> + (message-cite-original))))\r
+> >\r
+> > message-cite-original-without-signature?\r
+> \r
+> Perhaps it should be configurable (notmuch-reply-cite-function or\r
+> somesuch). I believe message-cite-original matches the behavior of the\r
+> old reply, which didn't strip signatures, but I don't have strong\r
+> feelings either way.\r
+\r
+We should probably stick with the original behavior, at least for now.\r
+\r
+I just noticed that message-cite-original calls mml-quote-region. How\r
+is it that we don't wind up double-quoting MML tags with this change?\r
projects / notmuch-archives.git / commitdiff