Re: [PATCH] convert bitmap to unsigned char

diff --git a/97/c0fdd004f9642502bf1d77fbaccf2b1cf37e7b b/97/c0fdd004f9642502bf1d77fbaccf2b1cf37e7b
new file mode 100644 (file)
index 0000000..01d38a5
--- /dev/null
+++ b/97/c0fdd004f9642502bf1d77fbaccf2b1cf37e7b
@@ -0,0 +1,135 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 01B8A431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 11 Feb 2013 10:54:13 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id B8uIba-sBZ6y for <notmuch@notmuchmail.org>;\r
+       Mon, 11 Feb 2013 10:54:12 -0800 (PST)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 1FC16431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 11 Feb 2013 10:54:12 -0800 (PST)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id 2D07F6DE0C03;\r
+       Mon, 11 Feb 2013 10:54:10 -0800 (PST)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 9B76E60C12; Tue, 12 Feb 2013 05:56:57 +1100 (EST)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Robert Mast <beheerder@tekenbeetziekten.nl>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] convert bitmap to unsigned char\r
+In-Reply-To: <1360501997-4967-1-git-send-email-beheerder@tekenbeetziekten.nl>\r
+References: <1359917491-17178-1-git-send-email-beheerder@tekenbeetziekten.nl>\r
+       <1360501997-4967-1-git-send-email-beheerder@tekenbeetziekten.nl>\r
+User-Agent: Notmuch/0.13.1 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 11 Feb 2013 10:56:51 -0800\r
+Message-ID: <87r4kmk7bg.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Cc: Robert Mast <beheerder@tekenbeetziekten.nl>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 11 Feb 2013 18:54:13 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+Robert Mast <beheerder@tekenbeetziekten.nl> writes:\r
+> ---\r
+\r
+Hi Robert,\r
+\r
+It looks like the git exercise is proving useful. Keep it up!\r
+\r
+If you look through the git logs a bit you'll find that the overwhelming\r
+convention is for a commit message to have a single-line summary\r
+followed by a (potentially longer) expanded comment.\r
+\r
+The convention I like best is for the single-line summary to\r
+efficiently  describe everything about "what" the patch does. If it's\r
+hard to fit this into a single line there's a good chance your patch\r
+should be split up. With your commit message here, the one-line summary\r
+is great, (and much better than in your first submission).\r
+\r
+The expanded comment should describe the "why" of the change. And here,\r
+your commit message doesn't have anything. So I'm left wondering why\r
+your commit exists. Does this save memory? Does this fix some type error\r
+or expected alignment somewhere? etc.\r
+\r
+Please re-submit your patch with a little more explanation of the\r
+motivation behind the patch.\r
+\r
+=2DCarl\r
+\r
+PS. I do know that you did have more in the commit message originally,\r
+and Austin recommended removing "snide" issues, (doubts and\r
+meta-questions about the patch---things that don't belong in the commit\r
+history).\r
+\r
+Your previous commit message was:\r
+\r
+  Reading it in detail I thought it allocated way too much memory and\r
+  didn't use the full size of the allocated unsigned ints for storing\r
+  bits.\r
+\r
+  Am I right, and is this the right way to patch code to notmuch?\r
+\r
+I'm not actually looking at the code in context now, so I can't render a\r
+correct commit message, but this attempted rewording should hopefully\r
+give you the idea:\r
+\r
+  Using char instead of int allows for simpler definitions of the\r
+  DOCIDSET macros so the code is easier to understand.\r
+\r
+  ---\r
+\r
+  Am I reading that correctly? Or is there also some space saving\r
+  happening here as well? Please re-submit a new patch with a commit\r
+  message that makes things clear one way or the other.\r
+\r
+Do you see how this "why" part of the commit message is ready to stand\r
+alone in our commit history (assuming it's correct and\r
+accepted). Meta-questions like "is this even a sane way of doing\r
+things?" are great to ask, and very helpful for code reviewers, but best\r
+placed after the "---" so that they don't become part of the commit\r
+message.\r
+\r
+Thanks for playing with notmuch!\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iEYEARECAAYFAlEZPvMACgkQ6JDdNq8qSWhuawCfZTraPY2wUSv62MTQl5qhHO99\r
+lo8An1xH+tz66hfppsPU7KtTq/YiSVsA\r
+=fzpL\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r