net-analyzer/pnp4nagios: use consistent perfdata directories.
authorMichael Orlitzky <mjo@gentoo.org>
Thu, 2 Nov 2017 20:42:36 +0000 (16:42 -0400)
committerMichael Orlitzky <mjo@gentoo.org>
Sat, 4 Nov 2017 23:37:22 +0000 (19:37 -0400)
Past revisions have stored the RRDtool data and the process_perdata.pl
logs in (for example) /var/nagios or /var/icinga, depending on whether
or you had Nagios or Icinga installed. That's silly: the data format
doesn't change, so it makes more sense to choose one location (now:
/var/lib/pnp) and stick with it.

Package-Manager: Portage-2.3.8, Repoman-2.3.3

net-analyzer/pnp4nagios/pnp4nagios-0.6.26-r5.ebuild [moved from net-analyzer/pnp4nagios/pnp4nagios-0.6.26-r4.ebuild with 78% similarity]

similarity index 78%
rename from net-analyzer/pnp4nagios/pnp4nagios-0.6.26-r4.ebuild
rename to net-analyzer/pnp4nagios/pnp4nagios-0.6.26-r5.ebuild
index c173abd999e420a822bad974e6e6f2728d717048..3e886eb89dc70a18b00f4befac012bc9ddf627a3 100644 (file)
@@ -38,27 +38,16 @@ RDEPEND="${DEPEND}
 PATCHES=( "${FILESDIR}/${PN}-0.6.14-makefile.patch" )
 
 src_configure() {
-       local var_dir user_group
-
-       if use icinga; then
-               var_dir=/var/lib/icinga
-               user_group=icinga
-       elif use icinga2; then
-               var_dir=/var/lib/icinga2
-               user_group=icinga
-       else
-               # Thanks to REQUIRED_USE, "use nagios" is the only other case.
-               var_dir=/var/nagios
-               user_group=nagios
-       fi
+       local user_group=nagios
+       ( use icinga || use icinga2 ) && user_group=icinga
 
        econf \
                --sysconfdir="${EPREFIX}"/etc/pnp \
                --datarootdir="${EPREFIX}"/usr/share/pnp \
-               --with-perfdata-dir="${EPREFIX}"${var_dir}/perfdata \
-               --with-nagios-user=${user_group} \
-               --with-nagios-group=${user_group} \
-               --with-perfdata-logfile="${EPREFIX}"${var_dir}/perfdata.log \
+               --with-nagios-user="${user_group}" \
+               --with-nagios-group="${user_group}" \
+               --with-perfdata-dir="${EPREFIX}"/var/lib/pnp/perfdata \
+               --with-perfdata-logfile="${EPREFIX}"/var/log/pnp/process_perfdata.log \
                --with-perfdata-spool-dir="${EPREFIX}"/var/spool/pnp
 }
 
@@ -88,6 +77,15 @@ src_install() {
                # server read it.
                fowners :apache /etc/pnp/process_perfdata.cfg
        fi
+
+       # The nagios or icinga user will also need to be able to write
+       # performance data to the perfdata-dir and perfdata-spool-dir
+       # directories.
+       local user_group=nagios
+       ( use icinga || use icinga2 ) && user_group=icinga
+       dodir /var/lib/pnp/{,perfdata} /var/log/pnp
+       fowners "${user_group}:${user_group}" /var/lib/pnp/{,perfdata}
+       fowners "${user_group}:${user_group}" /var/log/pnp
 }
 
 pkg_postinst() {