--- /dev/null
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 7EB4B40A2BC\r
+ for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 14:35:20 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id uNKwvZN9g6gh for <notmuch@notmuchmail.org>;\r
+ Fri, 24 Feb 2012 14:35:19 -0800 (PST)\r
+Received: from mail-we0-f181.google.com (mail-we0-f181.google.com\r
+ [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 9F5ED409F00\r
+ for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 14:35:19 -0800 (PST)\r
+Received: by werp13 with SMTP id p13so2017659wer.26\r
+ for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 14:35:18 -0800 (PST)\r
+Received-SPF: pass (google.com: domain of pieter@praet.org designates\r
+ 10.181.11.227 as permitted sender) client-ip=10.181.11.227; \r
+Authentication-Results: mr.google.com;\r
+ spf=pass (google.com: domain of pieter@praet.org\r
+ designates 10.181.11.227 as permitted sender)\r
+ smtp.mail=pieter@praet.org\r
+Received: from mr.google.com ([10.181.11.227])\r
+ by 10.181.11.227 with SMTP id el3mr8855363wid.18.1330122918473\r
+ (num_hops = 1); Fri, 24 Feb 2012 14:35:18 -0800 (PST)\r
+Received: by 10.181.11.227 with SMTP id el3mr7119811wid.18.1330122918390;\r
+ Fri, 24 Feb 2012 14:35:18 -0800 (PST)\r
+Received: from localhost ([109.131.181.26])\r
+ by mx.google.com with ESMTPS id m16sm14684643wie.9.2012.02.24.14.35.17\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Fri, 24 Feb 2012 14:35:17 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,\r
+ David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH 1/6] test: emacs: new tests "notmuch-show: {add,\r
+ remove} multiple tags {to, from} single message"\r
+In-Reply-To: <87ipiwjz85.fsf@gmail.com>\r
+References: <878vjtqhcg.fsf@praet.org>\r
+ <1330038554-10347-1-git-send-email-pieter@praet.org>\r
+ <87ipiwjz85.fsf@gmail.com>\r
+User-Agent: Notmuch/0.11.1+210~g6afc43e (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+Date: Fri, 24 Feb 2012 23:33:03 +0100\r
+Message-ID: <87aa47euao.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQnq4jDapgrWi38sBuho1ryjumNwatItN+GsxTHv8e7ef73v+l4zSHT9FC8WEzWT3rxmjhzG\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 24 Feb 2012 22:35:20 -0000\r
+\r
+On Fri, 24 Feb 2012 14:35:22 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> On Fri, 24 Feb 2012 00:09:09 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> > * test/emacs:\r
+> > \r
+> > - Rename subtests "{Add,Remove} tag from notmuch-show view" to\r
+> > "notmuch-show: {add,remove} single tag {to,from} single message"\r
+> > to be consistent with the following tests.\r
+> > \r
+> > - New subtest "notmuch-show: add multiple tags to single message":\r
+> > `notmuch-show-add-tag' ("+") can add multiple tags to a message.\r
+> > \r
+> > - New subtest "notmuch-show: remove multiple tags from single message":\r
+> > `notmuch-show-remove-tag' ("-") can remove multiple tags from a message.\r
+> > ---\r
+> \r
+> Would be nice to have another patch that moves notmuch-show tests to\r
+> emacs-show file.\r
+>\r
+\r
+TL;DR: It's on my todo list.\r
+\r
+Yeah, the Emacs test series *as a whole* desperately needs some\r
+reorganizing, not in the least because it's still severely\r
+lacking in coverage.\r
+\r
+Some more structure/consistency would considerably increase the\r
+feasibility (or at least reduce the PITAness...) of filling in\r
+the numerous blanks and reducing duplication of effort (regarding\r
+both hard- and wetware based cycles), as well as increasing the\r
+likelihood that developers (not looking in any specific direction)\r
+serve their code with a side dish of tests.\r
+\r
+Ideally (IMHO), it would be split up into separate files by mode,\r
+i.e. `notmuch-hello', `notmuch-search', `notmuch-show',\r
+`notmuch-{message,mua}', and those can be further divided into\r
+sections like navigation, tagging, visibility stuff, hooks, ...\r
+\r
+There's probably quite a number of implicit interdependencies that\r
+need to be taken care of though, and I (as well as others) still\r
+have a bunch of tests waiting to be applied, so we might want to do\r
+this gradually.\r
+\r
+\r
+> Regards,\r
+> Dmitry\r
+> \r
+> > test/emacs | 16 ++++++++++++++--\r
+> > 1 files changed, 14 insertions(+), 2 deletions(-)\r
+> > \r
+> > diff --git a/test/emacs b/test/emacs\r
+> > index b74cfa9..ec1dbb0 100755\r
+> > --- a/test/emacs\r
+> > +++ b/test/emacs\r
+> > @@ -112,18 +112,30 @@ test_emacs "(notmuch-search \"$os_x_darwin_thread\")\r
+> > output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+> > test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"\r
+> > \r
+> > -test_begin_subtest "Add tag from notmuch-show view"\r
+> > +test_begin_subtest "notmuch-show: add single tag to single message"\r
+> > test_emacs "(notmuch-show \"$os_x_darwin_thread\")\r
+> > (execute-kbd-macro \"+tag-from-show-view\")"\r
+> > output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+> > test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag-from-show-view unread)"\r
+> > \r
+> > -test_begin_subtest "Remove tag from notmuch-show view"\r
+> > +test_begin_subtest "notmuch-show: remove single tag from single message"\r
+> > test_emacs "(notmuch-show \"$os_x_darwin_thread\")\r
+> > (execute-kbd-macro \"-tag-from-show-view\")"\r
+> > output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+> > test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"\r
+> > \r
+> > +test_begin_subtest "notmuch-show: add multiple tags to single message"\r
+> > +test_emacs "(notmuch-show \"$os_x_darwin_thread\")\r
+> > + (execute-kbd-macro \"+tag1-from-show-view +tag2-from-show-view\")"\r
+> > +output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+> > +test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag1-from-show-view tag2-from-show-view unread)"\r
+> > +\r
+> > +test_begin_subtest "notmuch-show: remove multiple tags from single message"\r
+> > +test_emacs "(notmuch-show \"$os_x_darwin_thread\")\r
+> > + (execute-kbd-macro \"-tag1-from-show-view -tag2-from-show-view\")"\r
+> > +output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+> > +test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"\r
+> > +\r
+> > test_begin_subtest "Message with .. in Message-Id:"\r
+> > add_message [id]=123..456@example '[subject]="Message with .. in Message-Id"'\r
+> > test_emacs '(notmuch-search "id:\"123..456@example\"")\r
+> > -- \r
+> > 1.7.8.1\r
+> > \r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r
projects / notmuch-archives.git / commitdiff