Re: [PATCH 1/3] lib: fix NULL checks for filenames iterators

diff --git a/4e/178876547c032182f481788d115a184c1c9f95 b/4e/178876547c032182f481788d115a184c1c9f95
new file mode 100644 (file)
index 0000000..450bb0e
--- /dev/null
+++ b/4e/178876547c032182f481788d115a184c1c9f95
@@ -0,0 +1,68 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2C256431FB6\r
+       for <notmuch@notmuchmail.org>; Sat,  1 Sep 2012 19:34:54 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Ijrebvm0tUft for <notmuch@notmuchmail.org>;\r
+       Sat,  1 Sep 2012 19:34:53 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 99CFB431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  1 Sep 2012 19:34:53 -0700 (PDT)\r
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.89.108] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1T801R-0007Wp-MZ; Sat, 01 Sep 2012 23:34:52 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1T801M-0003iM-9o; Sat, 01 Sep 2012 23:34:44 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Sascha Silbe <sascha-ml-reply-to-2012-3@silbe.org>,\r
+       notmuch <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 1/3] lib: fix NULL checks for filenames iterators\r
+In-Reply-To: <1340555366-25891-2-git-send-email-sascha-pgp@silbe.org>\r
+References: <1340555366-25891-1-git-send-email-sascha-pgp@silbe.org>\r
+       <1340555366-25891-2-git-send-email-sascha-pgp@silbe.org>\r
+User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/24.1.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 01 Sep 2012 23:34:44 -0300\r
+Message-ID: <871uilcfuj.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Sep 2012 02:34:54 -0000\r
+\r
+Sascha Silbe <sascha-pgp@silbe.org> writes:\r
+\r
+> The API documentation (notmuch.h) states that the parameter may be NULL,\r
+> but the implementation only checked the current element, potentially\r
+> dereferencing a NULL pointer in the process.\r
+>\r
+\r
+Pushed this one patch.\r
+\r
+d\r