Bug #293730 - Fix bad || choices triggered in some cases inside
authorZac Medico <zmedico@gentoo.org>
Fri, 20 Nov 2009 06:07:41 +0000 (06:07 -0000)
committerZac Medico <zmedico@gentoo.org>
Fri, 20 Nov 2009 06:07:41 +0000 (06:07 -0000)
_dep_check_composite_db._visible() when --update is not enabled.

svn path=/main/trunk/; revision=14854

pym/_emerge/depgraph.py

index fa4b1079b22f6f547bc24d70670e27815f3974fe..73eff9fa935b9195d7777121b63990f6d8ef64cd 100644 (file)
@@ -5278,7 +5278,10 @@ class _dep_check_composite_db(portage.dbapi):
                        # conflicts).
                        highest_visible, in_graph = self._depgraph._select_package(
                                self._root, pkg.slot_atom)
-                       if pkg != highest_visible:
+                       # Note: highest_visible is not necessarily the real highest
+                       # visible, especially when --update is not enabled, so use
+                       # < operator instead of !=.
+                       if pkg < highest_visible:
                                return False
                elif in_graph != pkg:
                        # Mask choices for packages that would trigger a slot