Re: [PATCH 10/10] timegm: add portable implementation (Solaris support)

diff --git a/dc/534afcf9aa4ce464c7e8978132fb7abae9b03b b/dc/534afcf9aa4ce464c7e8978132fb7abae9b03b
new file mode 100644 (file)
index 0000000..e7e557f
--- /dev/null
+++ b/dc/534afcf9aa4ce464c7e8978132fb7abae9b03b
@@ -0,0 +1,101 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D1549431FB6\r
+       for <notmuch@notmuchmail.org>; Mon,  5 Nov 2012 09:36:49 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id WXqPXLYzdUQL for <notmuch@notmuchmail.org>;\r
+       Mon,  5 Nov 2012 09:36:48 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id C2783431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  5 Nov 2012 09:36:48 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 3E178100094;\r
+       Mon,  5 Nov 2012 19:36:48 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Blake Jones <blakej@foo.net>\r
+Subject: Re: [PATCH 10/10] timegm: add portable implementation (Solaris\r
+       support)\r
+In-Reply-To: <2592.1352130442@foo.net>\r
+References: <2592.1352130442@foo.net>\r
+User-Agent: Notmuch/0.14+81~gb8371cd (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 05 Nov 2012 19:36:47 +0200\r
+Message-ID: <m2a9uwyms0.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 05 Nov 2012 17:36:50 -0000\r
+\r
+On Mon, Nov 05 2012, Blake Jones wrote:\r
+\r
+>> Yet another idea for an alternative. Compile by entering 'sh xtimegm.c'\r
+>> and then run ./xtimegm\r
+>> \r
+>> Simple cases seems to work. Dst change may (or then may not) give one\r
+>> hour difference to the expected. The test "coverage" could be easily\r
+>> expanded to that ;)\r
+>> \r
+>> Hmm, I also found this:\r
+>> http://lists.gnu.org/archive/html/bug-gnulib/2003-09/msg00004.html\r
+>> which does 2 mktime's and one gmtime_r (without allocating tg!)...\r
+>> Pick any of these 3 -- or something different (e.g. less NIH if there is)\r
+>\r
+> Of these two, I would probably lean slightly toward the latter, in that\r
+> it relies more on libc for the time zone handling logic.\r
+>\r
+> But in general, this seems to me like a case where an explicit\r
+> implementation like mine is less prone to failure, because it doesn't\r
+> need to worry about time zones at all. \r
+\r
+Good point.\r
+\r
+> The other approaches rely on\r
+> letting libc do all the hard work of time zone manipulation, and then\r
+> reading the tea leaves to find a way to undo it.\r
+\r
+Did you look at the gnu libc version -- I bet it is pretty hairy...\r
+\r
+>  I would guess that if\r
+> some change in the time standards is going to break one of these\r
+> implementations, it's going to be some new time zone specification, not\r
+> a change in the number of days in a month. :)\r
+>\r
+> For what it's worth, I used the attached program to test my\r
+> implementation, and it passed.\r
+\r
+Thanks, It's nice to see your simple implementation passes these tests...\r
+\r
+Just for curiosity: What do you think lacks in your timegm() that it could\r
+not be promoted as 'complete timegm() solution'.\r
+\r
+In any way, including this timegm() function in compat suits me fine.\r
+\r
+>\r
+> Blake\r
+>\r
+\r
+Tomi\r