[PATCH v2 12/13] emacs: accept empty tag list in `notmuch-tag'

diff --git a/46/ff9eb120ecbdb0678f322922fbdc3df309d444 b/46/ff9eb120ecbdb0678f322922fbdc3df309d444
new file mode 100644 (file)
index 0000000..71e81fd
--- /dev/null
+++ b/46/ff9eb120ecbdb0678f322922fbdc3df309d444
@@ -0,0 +1,95 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5BABE431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 18:28:32 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id l-0ztimkQMUy for <notmuch@notmuchmail.org>;\r
+       Sun, 29 Jan 2012 18:28:31 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id EC93B421189\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 18:27:58 -0800 (PST)\r
+Received: by mail-bk0-f53.google.com with SMTP id 11so960260bke.26\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 18:27:58 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:date:message-id:x-mailer:in-reply-to:references;\r
+       bh=OK0Sm2NBMtyTBG2LqvCWVI2W5QUQOcJU9gqHoAofFEs=;\r
+       b=WAEx6/9IgCTG4rCVgcmgDM9u4YqqbBG82U/wHne7rf/Fu3AeD7QOHUxJpLyiYqhbd1\r
+       W8BzHveH9pJ4uilaG5sfzbqPeWVs6m1L4bdApu2stBDkEDU1aGUrjlqNkEz/ov87Qc+f\r
+       oAc2/0IVXa7eFk7CPdwxnJBw0Pjj7JmT7ZDjs=\r
+Received: by 10.204.152.15 with SMTP id e15mr7762044bkw.108.1327890478716;\r
+       Sun, 29 Jan 2012 18:27:58 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id z15sm31387095bkd.7.2012.01.29.18.27.57\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sun, 29 Jan 2012 18:27:58 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v2 12/13] emacs: accept empty tag list in `notmuch-tag'\r
+Date: Mon, 30 Jan 2012 06:26:21 +0400\r
+Message-Id: <1327890382-548-13-git-send-email-dmitry.kurochkin@gmail.com>\r
+X-Mailer: git-send-email 1.7.8.3\r
+In-Reply-To: <1327890382-548-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1327890382-548-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 02:28:32 -0000\r
+\r
+Since `notmuch-tag' is a non-interactive function and hence is meant\r
+to be invoked programmatically, it should accept zero tags.  Also, the\r
+tagging operations (bound to "*", "+", "-") would accept empty input\r
+without an error.\r
+---\r
+ emacs/notmuch.el |   10 +++++-----\r
+ 1 files changed, 5 insertions(+), 5 deletions(-)\r
+\r
+diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+index 7e8f185..1b7a835 100644\r
+--- a/emacs/notmuch.el\r
++++ b/emacs/notmuch.el\r
+@@ -555,15 +555,15 @@ messages instead of running (notmuch-call-notmuch-process \"tag\" ..)\r
+ directly, so that hooks specified in notmuch-before-tag-hook and\r
+ notmuch-after-tag-hook will be run."\r
+   ;; Perform some validation\r
+-  (when (null tags) (error "No tags given"))\r
+   (mapc (lambda (tag)\r
+         (unless (string-match-p "^[-+]\\S-+$" tag)\r
+           (error "Tag must be of the form `+this_tag' or `-that_tag'")))\r
+       tags)\r
+-  (run-hooks 'notmuch-before-tag-hook)\r
+-  (apply 'notmuch-call-notmuch-process\r
+-       (append (list "tag") tags (list "--" query)))\r
+-  (run-hooks 'notmuch-after-tag-hook))\r
++  (unless (null tags)\r
++    (run-hooks 'notmuch-before-tag-hook)\r
++    (apply 'notmuch-call-notmuch-process "tag"\r
++         (append tags (list "--" query)))\r
++    (run-hooks 'notmuch-after-tag-hook)))\r
+ \r
+ (defcustom notmuch-before-tag-hook nil\r
+   "Hooks that are run before tags of a message are modified.\r
+-- \r
+1.7.8.3\r
+\r