Re: [PATCH 1/2] Annotate internal_error with the attribute noreturn

diff --git a/96/197e06ffcd7e1b9ccc7eb69206d0cbfdfaa98f b/96/197e06ffcd7e1b9ccc7eb69206d0cbfdfaa98f
new file mode 100644 (file)
index 0000000..da1c410
--- /dev/null
+++ b/96/197e06ffcd7e1b9ccc7eb69206d0cbfdfaa98f
@@ -0,0 +1,75 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3BEA4431FAF\r
+       for <notmuch@notmuchmail.org>; Fri, 21 Sep 2012 13:31:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id CJsAeyzVXRex for <notmuch@notmuchmail.org>;\r
+       Fri, 21 Sep 2012 13:31:39 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id BE20F431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 21 Sep 2012 13:31:39 -0700 (PDT)\r
+Received: from convex-new.cs.unb.ca ([131.202.245.35])\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TF9sn-0001Mq-RQ; Fri, 21 Sep 2012 17:31:34 -0300\r
+Received: from bremner by convex-new.cs.unb.ca with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TF9sN-0001cA-ER; Fri, 21 Sep 2012 17:31:03 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] Annotate internal_error with the attribute noreturn\r
+In-Reply-To:\r
+ <1348231837-21700-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+References:\r
+ <1348231837-21700-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+User-Agent: Notmuch/0.14+20~g69843dd (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 21 Sep 2012 17:31:03 -0300\r
+Message-ID: <87fw6bdsoo.fsf@convex-new.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 21 Sep 2012 20:31:40 -0000\r
+\r
+Justus Winter <4winter@informatik.uni-hamburg.de> writes:\r
+\r
+> Annotating functions that do not return with the noreturn attribute\r
+> (which is understood by both gcc and clang) prevents static analyzers\r
+> from generating false positives (internal_error is used to terminate\r
+> the process and is used extensively in error handling code paths).\r
+>\r
+> Remove the return statement that was placed there to appease the\r
+> compiler. Functions annotated with noreturn are not supposed to return\r
+> any values.\r
+>\r
+\r
+This patch looks OK (although I don't know the pragma details).  Do you\r
+(or anyone) happen to know why _internal_error is an int function?\r
+Making it void wouldn't fix the problem with static analzers, but having\r
+an int function without a return looks ugly to me.\r
+\r
+d\r