Re: [PATCH v3 1/6] cli: new crypto structure to store crypto contexts and parameters...

diff --git a/73/a938dfcfcf01adad362a1c1aeb5b5e843807b7 b/73/a938dfcfcf01adad362a1c1aeb5b5e843807b7
new file mode 100644 (file)
index 0000000..16e4688
--- /dev/null
+++ b/73/a938dfcfcf01adad362a1c1aeb5b5e843807b7
@@ -0,0 +1,108 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3E40A431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 23 May 2012 10:35:04 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id QGZwY4vMHpm6 for <notmuch@notmuchmail.org>;\r
+       Wed, 23 May 2012 10:35:02 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0DDD2431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 23 May 2012 10:35:02 -0700 (PDT)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id 747982E50936;\r
+       Wed, 23 May 2012 10:34:59 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (unknown [137.151.175.56])\r
+       (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id ABC812E50B79;\r
+       Wed, 23 May 2012 10:34:56 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 6ECDC1E1; Wed, 23 May 2012 10:34:56 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH v3 1/6] cli: new crypto structure to store crypto contexts\r
+       and parameters, and functions to support it\r
+In-Reply-To:\r
+ <CAB+hUn_eapb9nxC2rnyRX7czoXELX-8KeWOCFe-eDtRw0OifOw@mail.gmail.com>\r
+References: <1337737430-21160-1-git-send-email-jrollins@finestructure.net>\r
+       <1337737430-21160-2-git-send-email-jrollins@finestructure.net>\r
+       <CAB+hUn_eapb9nxC2rnyRX7czoXELX-8KeWOCFe-eDtRw0OifOw@mail.gmail.com>\r
+User-Agent: Notmuch/0.13+24~g16915cd (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 23 May 2012 10:34:53 -0700\r
+Message-ID: <87396q7qde.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 23 May 2012 17:35:04 -0000\r
+\r
+--=-=-=\r
+\r
+On Tue, May 22 2012, Jani Nikula <jani@nikula.org> wrote:\r
+>> +/* for the specified protocol return the context pointer (initializing\r
+>> + * if needed) */\r
+>> +GMimeCryptoContext *\r
+>> +notmuch_crypto_get_context (notmuch_crypto_t *crypto, const char\r
+> *protocol)\r
+>> +{\r
+>> +    GMimeCryptoContext *cryptoctx = NULL;\r
+>\r
+> Isn't GMimeCryptoContext gmime 2.6 specific? It's #ifdeffed elsewhere at\r
+> least. Also affects the return type.\r
+\r
+Yes, good catch, Jani.  Thank you.  Will fix.\r
+\r
+>> +    if ((strcmp (protocol, "application/pgp-signature") == 0)\r
+>> +       || (strcmp (protocol, "application/pgp-encrypted") == 0)) {\r
+>\r
+> Is protocol guaranteed to be lower case?\r
+\r
+That's a good question.  I don't know.  I'll check and fix\r
+appropriately.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPvR++AAoJEO00zqvie6q8LwcP/1Dkf1kIHTcow27JWLSMd/D5\r
+Zpr/cRXNOPcmvNyeD8h9UeWAYfDoslYpH952q4k5qkX+UzGk1WzjDhVCaJc+qPk4\r
+G2eA6boKdJ+FxilFJejjPeeFULvuVjNnnaM/ZuLTgTr0aOBRalcgCFNFOyx0yoTg\r
+/sYtDR6bt/s8hsibnpMHlrYU0u9iy4Mfn9AEPjWnGeMnM3J7RsJVlR1tp0Q1z61o\r
+jNyPaHbdz+VZCjQjV171Cony7Ggx1eyzFeGFS38jKhtix6JUeAm/AaYv/tBvCs0h\r
+17Dmp9gAyuYHg34UA9nPGbZaBxt8Pbtilggg9bYXEv8f45sPGzbZ3mncCEqKfFVW\r
+8Xf1E0hINlo0mlyU7f1EW3O1nrfn9nOxwl728yP6eGumf12BN1b6mfrWygDTkOsj\r
+rqV/eR2pFVQ2RPmkTCqQ6THLELh3iLAdAdveGvl6KyM7H3XrH+KcuTKhQ1No6Asu\r
+ar7+4lU9ejOsn3AvgjAC/xvkO4PC5zFGXDi1O+iMXnkt71gem870aYZ+ZKiCTmO3\r
+x7wbnlyGgeH3P7FSTbLsdOwrLR2bxZwP3JPGZRatXL2K/s9MqnJEVzU5S57SfDJm\r
+orcblUQsvmpXCssEFcO5dm+5CcnsEzutZMVJoPRwReXvZhvWjVhrui0Gv+2N2oWt\r
+u/krc6Y10TW8N+WxYJbQ\r
+=Be01\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r