Re: [PATCH 01/18] cli: add stub for insert command

diff --git a/d1/7ab694f048b79cd2bbca7ae0eb763f60d61692 b/d1/7ab694f048b79cd2bbca7ae0eb763f60d61692
new file mode 100644 (file)
index 0000000..0948872
--- /dev/null
+++ b/d1/7ab694f048b79cd2bbca7ae0eb763f60d61692
@@ -0,0 +1,115 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EC3E8431FC2\r
+       for <notmuch@notmuchmail.org>; Mon, 19 Nov 2012 05:52:08 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id S8i58C1Vrzey for <notmuch@notmuchmail.org>;\r
+       Mon, 19 Nov 2012 05:52:08 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 53FCF431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 19 Nov 2012 05:52:08 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1TaRlb-0002cF-Ne; Mon, 19 Nov 2012 13:52:05 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1TaRlb-0007K7-Bs; Mon, 19 Nov 2012 13:52:03 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Peter Wang <novalazy@gmail.com>\r
+Subject: Re: [PATCH 01/18] cli: add stub for insert command\r
+In-Reply-To: <20121119233435.GD2063@hili.localdomain>\r
+References: <1343223767-9812-1-git-send-email-novalazy@gmail.com>\r
+       <87fw46q0f7.fsf@qmul.ac.uk>\r
+       <20121119233435.GD2063@hili.localdomain>\r
+User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 19 Nov 2012 13:52:02 +0000\r
+Message-ID: <871ufppunx.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 86498e1e3878552255a7faf36238ee97 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 19 Nov 2012 13:52:09 -0000\r
+\r
+\r
+Hi\r
+On Mon, 19 Nov 2012, Peter Wang <novalazy@gmail.com> wrote:\r
+> On Sun, 18 Nov 2012 17:35:23 +0000, Mark Walters <markwalters1009@gmail.com> wrote:\r
+>> \r
+>> Hi\r
+>> \r
+>> I have now been through essentially the whole series (except the tests)\r
+>> and broadly like it. Just to summarise my concerns from the individual\r
+>> replies here:\r
+>\r
+> Thanks for the review.\r
+>\r
+>> \r
+>> What should insert do when interrupted and is it safe? I am not\r
+>> knowledgeable enough to be confident about that.\r
+>\r
+> Do you mean cleaning up stray files?  Otherwise I think we just return\r
+> an error code, and then it's the caller's responsibility.\r
+\r
+It's more that I am concerned that we don't corrupt the database (or get\r
+into some inconsistent state). I have some recollection that there were some\r
+changes to notmuch new to try and make it interrupt safe but I don't\r
+know what they were or whether they apply here.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+>\r
+>> \r
+>> I think some of the talloc allocations need their return values\r
+>> checked. I am more worried about this here then in most of the rest of\r
+>> notmuch as we are writing to the database (and even to the mailstore\r
+>> itself).\r
+>\r
+> Will do.\r
+>\r
+> Peter\r