dev-libs/glib: fix potential issues in network-monitor-race test
authorMart Raudsepp <leio@gentoo.org>
Thu, 29 Nov 2018 15:24:07 +0000 (17:24 +0200)
committerMart Raudsepp <leio@gentoo.org>
Thu, 29 Nov 2018 15:24:41 +0000 (17:24 +0200)
Closes: https://bugs.gentoo.org/664106
Signed-off-by: Mart Raudsepp <leio@gentoo.org>
Package-Manager: Portage-2.3.52, Repoman-2.3.11

dev-libs/glib/files/2.56.2-network-monitor-race-test-iterations.patch [new file with mode: 0644]
dev-libs/glib/glib-2.56.2.ebuild

diff --git a/dev-libs/glib/files/2.56.2-network-monitor-race-test-iterations.patch b/dev-libs/glib/files/2.56.2-network-monitor-race-test-iterations.patch
new file mode 100644 (file)
index 0000000..1ddec6d
--- /dev/null
@@ -0,0 +1,36 @@
+From a90c578952219e740f24d9f2560f54f19ae7e906 Mon Sep 17 00:00:00 2001
+From: Philip Withnall <withnall@endlessm.com>
+Date: Wed, 11 Apr 2018 15:45:10 +0100
+Subject: [PATCH] tests: Lower number of iterations in network-monitor-race
+
+While 333 runs is very likely to reproduce the bug, Milan has previously
+reproduced it with as few as 9 runs. Since this test will be run by the
+CI machinery quite often, a lower number of runs each CI run will still
+probably catch any regressions over time.
+
+This reduces the total test runtime from 33s to 2s.
+
+https://bugzilla.gnome.org/show_bug.cgi?id=793727
+
+Signed-off-by: Philip Withnall <withnall@endlessm.com>
+Reviewed-by: nobody
+---
+ gio/tests/network-monitor-race.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/gio/tests/network-monitor-race.c b/gio/tests/network-monitor-race.c
+index 4b92c87a5..cadd62cee 100644
+--- a/gio/tests/network-monitor-race.c
++++ b/gio/tests/network-monitor-race.c
+@@ -18,7 +18,7 @@
+ #include <glib/glib.h>
+ #include <gio/gio.h>
+-#define MAX_RUNS 333
++#define MAX_RUNS 20
+ static gboolean
+ quit_loop (gpointer user_data)
+-- 
+2.17.0
+
index d8adde6c4e2a390c5422e5af8a91b095d7eca454..ea796fb94700dc08fbb25a8069af7bed6586e629 100644 (file)
@@ -115,6 +115,9 @@ src_prepare() {
                sed -i -e 's/ tests//' {.,gio,glib}/Makefile.am || die
        fi
 
+       # Less max runs in network monitor race test to avoid hitting timeout limits
+       eapply "${FILESDIR}"/${PV}-network-monitor-race-test-iterations.patch # included in 2.57.1
+
        # gdbus-codegen is a separate package
        eapply "${FILESDIR}"/${PN}-2.54.3-external-gdbus-codegen.patch