Re: [PATCH v2] emacs: display tags in notmuch-show with links

diff --git a/52/33252748a30aa14f75d04029934685bb292ac1 b/52/33252748a30aa14f75d04029934685bb292ac1
new file mode 100644 (file)
index 0000000..e571a4a
--- /dev/null
+++ b/52/33252748a30aa14f75d04029934685bb292ac1
@@ -0,0 +1,135 @@
+Return-Path: <damien.cassou@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id ADA82431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 07:42:34 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id GLiFa0-qqp3I for <notmuch@notmuchmail.org>;\r
+       Thu, 15 Nov 2012 07:42:34 -0800 (PST)\r
+Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com\r
+       [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E524C431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 07:42:33 -0800 (PST)\r
+Received: by mail-vb0-f53.google.com with SMTP id fc21so1826201vbb.26\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 07:42:33 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=mime-version:in-reply-to:references:from:date:message-id:subject:to\r
+       :cc:content-type;\r
+       bh=DjDqk7F5POo5ilBBApsbgS2kvJKhS2NfWRJWAloC8kQ=;\r
+       b=dcb4Ki8E3Lm04v8zvqnGFFjgnhQZKCTf77eNEwlKbSRFBXJXKfewEAWweZ6Ct2ICek\r
+       IFTq0l01n4H65ILhQwgpYah1qqsP/hFpYwoQNghGvDQsO+D54iZkdeMdD6QhZgL23fK1\r
+       POJ4jDEQ0d4cg3/6IGAVf501QeqEn6pHegh6Da+dPCqheHHE7Hz35He6NsVw0IwyeXov\r
+       zQzoqNDzzhdt/pkGD1dGFkZRJnnJowymzf06TZKaqg7hFMTVzK/1HIFTy+Wlk4ZBOaCW\r
+       A2V8ggLwLuVbk1RSbbgJOsPs7IvML39YnD3JbpeJFPfNlgKfK+LwSZh8TiiRXi4CBvy4\r
+       HGcQ==\r
+Received: by 10.220.227.70 with SMTP id iz6mr1890952vcb.45.1352994153264; Thu,\r
+       15 Nov 2012 07:42:33 -0800 (PST)\r
+MIME-Version: 1.0\r
+Received: by 10.58.143.51 with HTTP; Thu, 15 Nov 2012 07:42:12 -0800 (PST)\r
+In-Reply-To: <878va4xson.fsf@qmul.ac.uk>\r
+References: <1352565719-12397-1-git-send-email-damien.cassou@gmail.com>\r
+       <878va4xson.fsf@qmul.ac.uk>\r
+From: Damien Cassou <damien.cassou@gmail.com>\r
+Date: Thu, 15 Nov 2012 16:42:12 +0100\r
+Message-ID:\r
+ <CA+y5ggj8QFGuxQpFXfnf_sc5hwLYOT3zoXJ6tm0zvpF45YLR2A@mail.gmail.com>\r
+Subject: Re: [PATCH v2] emacs: display tags in notmuch-show with links\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Content-Type: text/plain; charset=ISO-8859-1\r
+Cc: notmuch mailing list <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 15 Nov 2012 15:42:34 -0000\r
+\r
+On Wed, Nov 14, 2012 at 1:41 PM, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> On the loading library issues I defer to Adam and Tomi.\r
+\r
+\r
+I think they are right and I will try to make my code do something\r
+good by default and do something better if header-button is detected.\r
+\r
+\r
+> I do have a couple of comments on the current version\r
+> though. First the patch is very big. I would prefer it split into\r
+> several pieces\r
+\r
+\r
+do you want me to send totally separate emails or do you want me to\r
+send 1 discussion of multiple emails (with 0/4, 1/4, 2/4,...) ?\r
+\r
+\r
+> something like:\r
+>\r
+> 1) Add tags to the headerline but not clickable\r
+\r
+\r
+makes perfect sense\r
+\r
+\r
+> 2) Add the header-button library if appropriate\r
+\r
+\r
+I will try the other approach of not embedding the library in notmuch\r
+\r
+\r
+> 3) Add notmuch-tagger and change headerline to buttonize the tags\r
+\r
+\r
+makes perfect sense. The patch will buttonize the links if\r
+header-button is present and nothing otherwise.\r
+\r
+\r
+> 4) Add the tests.\r
+\r
+ok\r
+\r
+\r
++ 5) Add buttons to tags in the body\r
+\r
+\r
+>> +(defun notmuch-tagger-present-tags (tags &optional headerline)\r
+>> +  "Return a property list which nicely presents all TAGS.\r
+>> +\r
+>> +If HEADERLINE is non-nil the returned list will be ready for\r
+>> +inclusion in the buffer's header-line. HEADERLINE must be nil in\r
+>> +all other cases."\r
+>\r
+> I find it odd to say what it returns if HEADERLINE is non-nil and then\r
+> say otherwise HEADERLINE must be nil. Could you say what it returns in\r
+> the nil case? Something along them lines of\r
+>\r
+> "if HEADERLINE is non-nil the returned will be ready for inclusion in\r
+> the buffer's header-line (i.e., will use header-buttons if\r
+> available). Otherwise it returns a list?? ready for inclusion in a\r
+> buffer."\r
+\r
+thank you for the comment, I will fix it and propose new patches\r
+\r
+\r
+--\r
+Damien Cassou\r
+http://damiencassou.seasidehosting.st\r
+\r
+"Success is the ability to go from one failure to another without\r
+losing enthusiasm."\r
+Winston Churchill\r