--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 8D21C429E27\r
+ for <notmuch@notmuchmail.org>; Sun, 6 Jan 2013 13:12:43 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id E-JGUrVOur4V for <notmuch@notmuchmail.org>;\r
+ Sun, 6 Jan 2013 13:12:34 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU\r
+ [18.9.25.12])\r
+ by olra.theworths.org (Postfix) with ESMTP id ABDB1431FD4\r
+ for <notmuch@notmuchmail.org>; Sun, 6 Jan 2013 13:12:34 -0800 (PST)\r
+X-AuditID: 1209190c-b7fa86d000001d37-9f-50e9e8c22cac\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+ by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 38.F7.07479.2C8E9E05; Sun, 6 Jan 2013 16:12:34 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r06LCXuO019829; \r
+ Sun, 6 Jan 2013 16:12:34 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id r06LCV2P025193\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Sun, 6 Jan 2013 16:12:33 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1TrxWB-0002bC-I2; Sun, 06 Jan 2013 16:12:31 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3] emacs: Use the minibuffer for CLI error reporting\r
+In-Reply-To: <87ehi1j32b.fsf@qmul.ac.uk>\r
+References: <1357174222-25132-1-git-send-email-amdragon@mit.edu>\r
+ <1357249669-9706-1-git-send-email-amdragon@mit.edu>\r
+ <87ehi1j32b.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.14+236~gf64406d (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Sun, 06 Jan 2013 16:12:31 -0500\r
+Message-ID: <87y5g6j9s0.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFupileLIzCtJLcpLzFFi42IR4hTV1j304mWAwYPHPBY3WrsZLfbs87JY\r
+ PZfH4vrNmcwOLB53T3N57Jx1l93j2apbzB5bDr1nDmCJ4rJJSc3JLEst0rdL4MrY/u4Ra8EG\r
+ qYo326eyNzBOEu1i5OSQEDCRuPpuAQuELSZx4d56NhBbSGAfo8Sf+0A2F5C9nlHiUe9WFgjn\r
+ ApPE7Ib/7BDOEkaJjtlXmUFa2AQ0JLbtX84IYosIuEo8/fYZLM4sYCixZdpbdhBbWMBToqWh\r
+ DWwFJ1D95DdLWSDWTWCUmLlfHsQWFYiXeH7vG1icRUBVYuq5v2A2L9CpB39PY4WwBSVOznzC\r
+ AjFfS+LGv5dMExgFZyFJzUKSWsDItIpRNiW3Sjc3MTOnODVZtzg5MS8vtUjXUC83s0QvNaV0\r
+ EyM4mCV5djC+Oah0iFGAg1GJh/fCzhcBQqyJZcWVuYcYJTmYlER59959GSDEl5SfUpmRWJwR\r
+ X1Sak1p8iFGCg1lJhHffMaAcb0piZVVqUT5MSpqDRUmc93LKTX8hgfTEktTs1NSC1CKYrAwH\r
+ h5IEb/pzoEbBotT01Iq0zJwShDQTByfIcB6g4YYgNbzFBYm5xZnpEPlTjLocDS9vPGUUYsnL\r
+ z0uVEuflegpUJABSlFGaBzcHloReMYoDvSXMawkyigeYwOAmvQJawgS0JPXxc5AlJYkIKakG\r
+ RjfP+fnWkeLiOvab42Uu3D33wJuzwCUpXdh9ovLlk4KZF6svmH+3EXSzmu5t4Du77/zF2NDj\r
+ 3pIWZgf9eP6mW3z6nsvivcnw26Ur4v4FBcobwrynt+gf+yVQ8+Thxt2yV6yUckPORtv8fFnZ\r
+ rl+2b9PXlAyTEtvv0+e/mHnGvPoRo83X+LgGJZbijERDLeai4kQAO9Efhx0DAAA=\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 06 Jan 2013 21:12:43 -0000\r
+\r
+On Thu, 03 Jan 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> On Thu, 03 Jan 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+>> We recently switched to popping up a buffer to report CLI errors, but\r
+>> this was too intrusive, especially for transient errors and especially\r
+>> since we made fewer things ignore errors. This patch changes this to\r
+>> display a basic error message in the minibuffer (using Emacs' usual\r
+>> error handling path) and, if there are additional details, to log\r
+>> these to a separate error buffer and reference the error buffer from\r
+>> the minibuffer message. This is more in line with how Emacs typically\r
+>> handles errors, but makes the details available to the user without\r
+>> flooding them with the details.\r
+>>\r
+>> Given this split, we pare down the basic message and make it more\r
+>> user-friendly, and also make the verbose message even more detailed\r
+>> (and more debugging-oriented).\r
+>> ---\r
+>>\r
+>> This version fixes two hard-coded paths in the tests.\r
+>\r
+>\r
+> This version looks good to me but I have one query we may like to\r
+> consider. \r
+>\r
+> At the moment notmuch-call-notmuch-process returns the stderr mixed with\r
+> stdout and we might like to separate that out (particularly as the error\r
+> message lists stderr and stdout separately and in this case it all gets\r
+> called stdout).\r
+\r
+This sounds like a good idea to me, though I'd rather do it as a\r
+separate patch. Your patch looks good to me (modulo commit message,\r
+obviously). Care to roll an official patch?\r
+\r
+As I mentioned elsewhere, there are several direct calls to notmuch that\r
+don't go through any of this error handling (for example,\r
+`notmuch-call-notmuch-process' is only used in 'notmuch-tag'). It would\r
+be great if Someone (TM) cleaned this up.\r
+\r
+> I attach a patch that does this: I am not really familiar with this so I\r
+> just took Austin's code from notmuch-call-notmuch-json.\r
+>\r
+> Austin: obviously feel free to fold this into your patch if you think\r
+> appropriate.\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+> From b73395c8efb57111bd4de281797004747de6c2ed Mon Sep 17 00:00:00 2001\r
+> From: Mark Walters <markwalters1009@gmail.com>\r
+> Date: Thu, 3 Jan 2013 22:25:02 +0000\r
+> Subject: [PATCH] tweak notmuch-call-notmuch-process\r
+>\r
+> ---\r
+> emacs/notmuch.el | 10 +++++++---\r
+> 1 files changed, 7 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index c98a4fe..4f7ee2c 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -540,9 +540,13 @@ If notmuch exits with a non-zero status, output from the process\r
+> will appear in a buffer named \"*Notmuch errors*\" and an error\r
+> will be signaled."\r
+> (with-temp-buffer\r
+> - (let ((status (apply #'call-process notmuch-command nil t nil args)))\r
+> - (notmuch-check-exit-status status (cons notmuch-command args)\r
+> - (buffer-string)))))\r
+> + (let ((err-file (make-temp-file "nmerr")))\r
+> + (unwind-protect\r
+> + (let ((status (apply #'call-process\r
+> + notmuch-command nil (list t err-file) nil args)))\r
+> + (notmuch-check-exit-status status (cons notmuch-command args)\r
+> + (buffer-string) err-file))\r
+> + (delete-file err-file)))))\r
+> \r
+> (defun notmuch-search-set-tags (tags &optional pos)\r
+> (let ((new-result (plist-put (notmuch-search-get-result pos) :tags tags)))\r
+> -- \r
+> 1.7.9.1\r
projects / notmuch-archives.git / commitdiff