Re: [PATCH 0/7] Various fixes for the Go bindings
authorAustin Clements <amdragon@MIT.EDU>
Wed, 18 Jul 2012 20:51:40 +0000 (16:51 +2000)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:48:24 +0000 (09:48 -0800)
6d/f50378d79257111498f30b32c5780989255437 [new file with mode: 0644]

diff --git a/6d/f50378d79257111498f30b32c5780989255437 b/6d/f50378d79257111498f30b32c5780989255437
new file mode 100644 (file)
index 0000000..60834c3
--- /dev/null
@@ -0,0 +1,95 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 159DF431FC0\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jul 2012 13:51:44 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id QI0Q9eMx2e0M for <notmuch@notmuchmail.org>;\r
+       Wed, 18 Jul 2012 13:51:43 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU\r
+       [18.9.25.12])\r
+       by olra.theworths.org (Postfix) with ESMTP id 946FE431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jul 2012 13:51:43 -0700 (PDT)\r
+X-AuditID: 1209190c-b7f806d000006b87-90-500721df9e0b\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id EE.97.27527.FD127005; Wed, 18 Jul 2012 16:51:43 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q6IKpg1J004671; \r
+       Wed, 18 Jul 2012 16:51:42 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6IKpepF007930\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Wed, 18 Jul 2012 16:51:41 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SrbDg-0001Ez-Jp; Wed, 18 Jul 2012 16:51:40 -0400\r
+Date: Wed, 18 Jul 2012 16:51:40 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Adrien Bustany <adrien@bustany.org>\r
+Subject: Re: [PATCH 0/7] Various fixes for the Go bindings\r
+Message-ID: <20120718205140.GW31670@mit.edu>\r
+References: <1342636475-16057-1-git-send-email-adrien@bustany.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1342636475-16057-1-git-send-email-adrien@bustany.org>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IR4hRV1r2vyB5g8Gkmv8X6O2vZLK7fnMns\r
+       wOTx8cA9Jo9nq24xBzBFcdmkpOZklqUW6dslcGV8+7aIuWAvW8XL/fMZGxins3YxcnJICJhI\r
+       XH4/ixHCFpO4cG89WxcjF4eQwD5GiYZda5ghnA2MEhfXrGaCcE4ySczedIkdwlnCKHHhwGqw\r
+       fhYBVYlrryazgdhsAhoS2/YvB4uLCKhL7OhsB7OZBaQlvv1uZgKxhQWsJN68/sgOYvMK6EhM\r
+       +vwcrEZIwEli7bzHzBBxQYmTM5+wQPRqSdz49xKolwNszvJ/HCBhTgFniRtbH4ONERVQkZhy\r
+       chvbBEahWUi6ZyHpnoXQvYCReRWjbEpulW5uYmZOcWqybnFyYl5eapGuoV5uZoleakrpJkZw\r
+       YEvy7GB8c1DpEKMAB6MSD++DXawBQqyJZcWVuYcYJTmYlER5PwmxBwjxJeWnVGYkFmfEF5Xm\r
+       pBYfYpTgYFYS4X0gCJTjTUmsrEotyodJSXOwKInzXk656S8kkJ5YkpqdmlqQWgSTleHgUJLg\r
+       FQNGsJBgUWp6akVaZk4JQpqJgxNkOA/QcBeQGt7igsTc4sx0iPwpRkUpcV5VkIQASCKjNA+u\r
+       F5Z4XjGKA70izOsKUsUDTFpw3a+ABjMBDeYuZgMZXJKIkJICJpu1k42eVz6sLWfUCDqq3y4t\r
+       PiOB6fJkhVeCO2Y+bjFw/Ruzu8tp6ZwLQo/ThAv3m3hKFtW7PVWWSp2o2X3nlcbq1Qlr89Im\r
+       GmyYGarcfL4kIO5IilkY47YfZ0zYw1TfeIssu6W1fQ7Li08LD/0+qbe/yPCwk4zjVmP+efry\r
+       050XP3s0+7WhsRJLcUaioRZzUXEiANdN180XAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Jul 2012 20:51:44 -0000\r
+\r
+This series looks good to me other than the few things I commented on.\r
+It's nice to see the Go bindings get a bit of love!\r
+\r
+Quoth Adrien Bustany on Jul 18 at  9:34 pm:\r
+> The following patches fix some serious memory management issues with\r
+> the Go bindings, and add some missing functions as well.\r
+> \r
+> Adrien Bustany (7):\r
+>   go: Use iota in enum bindings\r
+>   go: Add missing MESSAGE_FLAG_EXCLUDED in Flag enum\r
+>   go: Allow notmuch objects to be garbage collected\r
+>   go: Make Destroy functions safe to call several times\r
+>   go: Partially bind notmuch_database_upgrade\r
+>   go: Bind notmuch_database_find_message_by_filename\r
+>   go: Bind notmuch_thread_t functions\r
+> \r
+>  bindings/go/src/notmuch/notmuch.go |  471 ++++++++++++++++++++++++++++++++++--\r
+>  1 files changed, 447 insertions(+), 24 deletions(-)\r
+> \r