[PATCH v2 11/13] show: Convert show_message to use sprinter

diff --git a/19/9c08beb160d51c473d1acf243ead5f7ec7febf b/19/9c08beb160d51c473d1acf243ead5f7ec7febf
new file mode 100644 (file)
index 0000000..3beae4f
--- /dev/null
+++ b/19/9c08beb160d51c473d1acf243ead5f7ec7febf
@@ -0,0 +1,163 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A8986431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 27 Jul 2012 21:29:26 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id sLQN313KXklS for <notmuch@notmuchmail.org>;\r
+       Fri, 27 Jul 2012 21:29:25 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU\r
+       [18.7.68.37])\r
+       by olra.theworths.org (Postfix) with ESMTP id 63907431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 27 Jul 2012 21:29:25 -0700 (PDT)\r
+X-AuditID: 12074425-b7f9b6d0000008c4-8f-50136aa4e5f9\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 95.70.02244.4AA63105; Sat, 28 Jul 2012 00:29:24 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q6S4TNF4017242; \r
+       Sat, 28 Jul 2012 00:29:23 -0400\r
+Received: from drake.dyndns.org\r
+       (209-6-116-242.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com\r
+       [209.6.116.242]) (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6S4TL3V027362\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Sat, 28 Jul 2012 00:29:22 -0400 (EDT)\r
+Received: from amthrax by drake.dyndns.org with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SuyeW-0002XD-T4; Sat, 28 Jul 2012 00:29:20 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v2 11/13] show: Convert show_message to use sprinter\r
+Date: Sat, 28 Jul 2012 00:29:12 -0400\r
+Message-Id: <1343449754-9010-12-git-send-email-amdragon@mit.edu>\r
+X-Mailer: git-send-email 1.7.10\r
+In-Reply-To: <1343449754-9010-1-git-send-email-amdragon@mit.edu>\r
+References: <1343449754-9010-1-git-send-email-amdragon@mit.edu>\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsUixCmqrLskSzjA4NtqbYu9De2MFqvn8lhc\r
+       vzmT2eLNynmsDiweO2fdZfdYvGk/m8fhrwtZPJ6tusUcwBLFZZOSmpNZllqkb5fAlfHg3mWm\r
+       gi6RimNrbrE1MD7l72Lk5JAQMJE4MOkPO4QtJnHh3nq2LkYuDiGBfYwSK86eYIZwNjBKnOhY\r
+       AJV5xCTRu3wzI4Qzl1Fi2qc9rCD9bAIaEtv2L2cEsUUEpCV23p0NFOfgYBbIk3i8VgIkLCzg\r
+       IrFo6mMWEJtFQFXiw7dVYK28Ag4St08fYoU4Q17i6f0+NhCbEyi++eUHZhBbSMBeYvfkDawT\r
+       GPkXMDKsYpRNya3SzU3MzClOTdYtTk7My0st0rXQy80s0UtNKd3ECAo4dhfVHYwTDikdYhTg\r
+       YFTi4T11RShAiDWxrLgy9xCjJAeTkihvVLhwgBBfUn5KZUZicUZ8UWlOavEhRgkOZiUR3p2C\r
+       QDnelMTKqtSifJiUNAeLkjjvjZSb/kIC6YklqdmpqQWpRTBZGQ4OJQne7ZlAjYJFqempFWmZ\r
+       OSUIaSYOTpDhPEDD14DU8BYXJOYWZ6ZD5E8xKkqJ804CSQiAJDJK8+B6YQnhFaM40CvCvNdA\r
+       qniAyQSu+xXQYCagwRbRQiCDSxIRUlINjBUpeeurrh8M38qTGSb+rcy8Zlftyp079lz9JH2K\r
+       d9Jzxh2cNk9fbfn0wP96wO6yKz/vcpbeXOmh/iE/4oYGR3jG/4U5fS9WMl5i141a25x1VWmb\r
+       lWoyZ4H+P/0Hx0xmuRxvKZ38xid/8oNZz9I1v09q0bqf5zbDjbfmh7jJ0hk8m3b/fTpt5U8l\r
+       luKMREMt5qLiRADlxulU4wIAAA==\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 28 Jul 2012 04:29:27 -0000\r
+\r
+Unlike the previous patches, this function is used for all formats.\r
+However, for formats other than the JSON format, the sprinter methods\r
+used by show_message are all no-ops, so this code continues to\r
+function correctly for all of the formats.\r
+\r
+Converting show_message eliminates show_null_message in the process,\r
+since this maps directly to an sprinter method.\r
+---\r
+ notmuch-show.c |   31 +++++--------------------------\r
+ 1 file changed, 5 insertions(+), 26 deletions(-)\r
+\r
+diff --git a/notmuch-show.c b/notmuch-show.c\r
+index b9d9f5d..ec3e861 100644\r
+--- a/notmuch-show.c\r
++++ b/notmuch-show.c\r
+@@ -842,15 +842,6 @@ format_part_raw (unused (const void *ctx), unused (sprinter_t *sp),\r
+ }\r
+ \r
+ static notmuch_status_t\r
+-show_null_message (const notmuch_show_format_t *format)\r
+-{\r
+-    /* Output a null message. Currently empty for all formats except Json */\r
+-    if (format->null_message)\r
+-      printf ("%s", format->null_message);\r
+-    return NOTMUCH_STATUS_SUCCESS;\r
+-}\r
+-\r
+-static notmuch_status_t\r
+ show_message (void *ctx,\r
+             const notmuch_show_format_t *format,\r
+             sprinter_t *sp,\r
+@@ -884,23 +875,16 @@ show_messages (void *ctx,\r
+     notmuch_message_t *message;\r
+     notmuch_bool_t match;\r
+     notmuch_bool_t excluded;\r
+-    int first_set = 1;\r
+     int next_indent;\r
+     notmuch_status_t status, res = NOTMUCH_STATUS_SUCCESS;\r
+ \r
+-    if (format->message_set_start)\r
+-      fputs (format->message_set_start, stdout);\r
++    sp->begin_list (sp);\r
+ \r
+     for (;\r
+        notmuch_messages_valid (messages);\r
+        notmuch_messages_move_to_next (messages))\r
+     {\r
+-      if (!first_set && format->message_set_sep)\r
+-          fputs (format->message_set_sep, stdout);\r
+-      first_set = 0;\r
+-\r
+-      if (format->message_set_start)\r
+-          fputs (format->message_set_start, stdout);\r
++      sp->begin_list (sp);\r
+ \r
+       message = notmuch_messages_get (messages);\r
+ \r
+@@ -915,12 +899,9 @@ show_messages (void *ctx,\r
+               res = status;\r
+           next_indent = indent + 1;\r
+       } else {\r
+-          status = show_null_message (format);\r
++          sp->null (sp);\r
+       }\r
+ \r
+-      if (!status && format->message_set_sep)\r
+-          fputs (format->message_set_sep, stdout);\r
+-\r
+       status = show_messages (ctx,\r
+                               format, sp,\r
+                               notmuch_message_get_replies (message),\r
+@@ -931,12 +912,10 @@ show_messages (void *ctx,\r
+ \r
+       notmuch_message_destroy (message);\r
+ \r
+-      if (format->message_set_end)\r
+-          fputs (format->message_set_end, stdout);\r
++      sp->end (sp);\r
+     }\r
+ \r
+-    if (format->message_set_end)\r
+-      fputs (format->message_set_end, stdout);\r
++    sp->end (sp);\r
+ \r
+     return res;\r
+ }\r
+-- \r
+1.7.10\r
+\r