Re: [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook, etc

diff --git a/d9/87b024fa5b0cc9e2d247c5c85aca0136d4e541 b/d9/87b024fa5b0cc9e2d247c5c85aca0136d4e541
new file mode 100644 (file)
index 0000000..dcbb772
--- /dev/null
+++ b/d9/87b024fa5b0cc9e2d247c5c85aca0136d4e541
@@ -0,0 +1,123 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 53028431FB6\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Sep 2012 09:00:53 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id xEbL1FDvkx8a for <notmuch@notmuchmail.org>;\r
+       Sun,  2 Sep 2012 09:00:52 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 47D55431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Sep 2012 09:00:52 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id C12521000E5;\r
+       Sun,  2 Sep 2012 19:00:58 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook,\r
+       etc\r
+In-Reply-To: <cover.1346596156.git.jani@nikula.org>\r
+References: <cover.1346596156.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 02 Sep 2012 19:00:58 +0300\r
+Message-ID: <m2sjb0wh1h.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Sep 2012 16:00:53 -0000\r
+\r
+On Sun, Sep 02 2012, Jani Nikula <jani@nikula.org> wrote:\r
+\r
+> Hi all, v2 of [1] addressing review comments: added NEWS, improved\r
+> documentation, made the query customizable.\r
+\r
+Hi Jani\r
+\r
+Just today I was looking these older patches below and was about to\r
+comment those when these arrived.\r
+\r
+I think the idea is great, but there is just something in the integration...\r
+\r
+> [1] id:"37899e28dbf67e4620a53279a869be3174c02d6f.1339775602.git.jani@nikula.org"\r
+\r
+I see hooks a great way to extend some functionality outside of that\r
+package instead of touching it. Also, maybe I've been using emacs too\r
+much as these hooks as defcustom seems little weird. Yet as I grepped\r
+'defcustom.*hook' through emacs-24.2/lisp/*.el and I got many hits --\r
+and some of those even added some ":options" to those (but most those\r
+I looked did not specify anything to choose from).\r
+\r
+That said, I am not _personally_ very thilled about the idea of defining\r
+functions inside notmuch and then that work via a hook...\r
+\r
+Therefore I'd like to propose an alternative way to do this:\r
+\r
+Integrate this change status information to the notmuch-hello-insert-header ()\r
+function, disabled by default -- and add customization variable which\r
+can be used to enable it. like:\r
+\r
+ Welcome to notmuch. You have 22 195 messages.\r
+\r
+ Welcome to notmuch. You have 22 185 messages (-10).\r
+ Welcome to notmuch. You have 22 205 messages (+20).\r
+\r
+or second line for the status info.\r
+\r
+\r
+I would enable this feature if implemented this way. Also I would enable\r
+this implemented like this patch series if this is to be applied (I just \r
+give +-0). But this could also be implemented as a hook outside of notmuch\r
+relying that variable no-display is available in dynamic scope -- but without\r
+promising the variable will be there.\r
+\r
+> BR,\r
+> Jani.\r
+\r
+Finally, I hope my comment does not silence the audience but that this\r
+sparks more comment and good solution is used for this useful feature.\r
+\r
+Tomi\r
+\r
+>\r
+> Jani Nikula (5):\r
+>   emacs: document the notmuch-hello no-display argument\r
+>   emacs: add no-display arg to notmuch-hello-refresh-hook\r
+>   test: fix hook-counter to accept the new no-display param\r
+>   emacs: add notmuch hello refresh hook to display message count change\r
+>   NEWS: notmuch-hello refresh hook changes\r
+>\r
+>  NEWS                   |   18 ++++++++++++++++++\r
+>  emacs/notmuch-hello.el |   46 ++++++++++++++++++++++++++++++++++++++++++++--\r
+>  test/test-lib.el       |    2 +-\r
+>  3 files changed, 63 insertions(+), 3 deletions(-)\r
+>\r
+> -- \r
+> 1.7.9.5\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r