Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects.

diff --git a/f3/984dc20ae74cb5fb07d46d4f0cb8e9e4830987 b/f3/984dc20ae74cb5fb07d46d4f0cb8e9e4830987
new file mode 100644 (file)
index 0000000..1855d2a
--- /dev/null
+++ b/f3/984dc20ae74cb5fb07d46d4f0cb8e9e4830987
@@ -0,0 +1,122 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A9CC3431FBC\r
+       for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 02:31:44 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ztT+UfpYkXVz for <notmuch@notmuchmail.org>;\r
+       Fri, 27 Jan 2012 02:31:44 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 147B5431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 02:31:44 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Rqj5q-0000Pp-3P; Fri, 27 Jan 2012 10:31:42 +0000\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+       helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Rqj5p-0001ct-79; Fri, 27 Jan 2012 10:31:41 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects.\r
+In-Reply-To: <1327499314-7887-4-git-send-email-dme@dme.org>\r
+References: <1327496913-4946-1-git-send-email-dme@dme.org>\r
+       <1327499314-7887-1-git-send-email-dme@dme.org>\r
+       <1327499314-7887-4-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.11+107~g185f859 (http://notmuchmail.org) Emacs/23.2.1\r
+       (i486-pc-linux-gnu)\r
+Date: Fri, 27 Jan 2012 10:32:43 +0000\r
+Message-ID: <87ty3h4er8.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: d5b810ae135be3edf305c826e6d3381f (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 27 Jan 2012 10:31:44 -0000\r
+\r
+\r
+I am very much not a lisp expert but for what it's worth I read/reviewed\r
+the patches and like them with a couple of minor queries that I am happy\r
+to be overruled on\r
+\r
+The patch 1/3 seems to set the show buffer line to *[No Subject]* where\r
+it used to be just [No Subject]. (I have no preference: I just wasn't\r
+sure if that was intentional.\r
+\r
+Patch 2/3 is obviously fine and good.\r
+\r
+Patch 3/3:\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index e6a5b31..c602b3e 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -985,7 +985,7 @@ buffer."\r
+>        (notmuch-show-next-open-message))\r
+>  \r
+>      ;; Set the header line to the subject of the first open message.\r
+> -    (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-subject)))\r
+> +    (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-pretty-subject)))\r
+>  \r
+>      (notmuch-show-mark-read)))\r
+>  \r
+> @@ -1216,6 +1216,9 @@ Some useful entries are:\r
+>  (defun notmuch-show-get-depth ()\r
+>    (notmuch-show-get-prop :depth))\r
+>  \r
+> +(defun notmuch-show-get-pretty-subject ()\r
+> +  (notmuch-prettify-subject (notmuch-show-get-subject)))\r
+> +\r
+>  (defun notmuch-show-set-tags (tags)\r
+>    "Set the tags of the current message."\r
+>    (notmuch-show-set-prop :tags tags)\r
+\r
+As far as I can see notmuch-show-get-pretty-subject is only called once\r
+so I wondered why you bothered with a new function. But as I say I have\r
+almost zero lisp experience so no feel for lisp style.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+(sorry for the resend: I sent from the wrong address the first time)\r