--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 8BCD2431FAF\r
+ for <notmuch@notmuchmail.org>; Sat, 4 Feb 2012 11:11:25 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id b8aG2iGrKKgn for <notmuch@notmuchmail.org>;\r
+ Sat, 4 Feb 2012 11:11:24 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id EBFAC431FBC\r
+ for <notmuch@notmuchmail.org>; Sat, 4 Feb 2012 11:11:20 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Rtl15-0002yS-4v; Sat, 04 Feb 2012 19:11:19 +0000\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Rtl14-000355-Lk; Sat, 04 Feb 2012 19:11:19 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] emacs: Improve prompting for user address when\r
+ replying.\r
+In-Reply-To: <87ipjmo4ri.fsf@nikula.org>\r
+References: <1328375350-10352-1-git-send-email-markwalters1009@gmail.com>\r
+ <1328375350-10352-3-git-send-email-markwalters1009@gmail.com>\r
+ <87ipjmo4ri.fsf@nikula.org>\r
+User-Agent: Notmuch/0.11+152~g4d737cf (http://notmuchmail.org) Emacs/23.2.1\r
+ (i486-pc-linux-gnu)\r
+Date: Sat, 04 Feb 2012 19:12:28 +0000\r
+Message-ID: <87haz6h0pv.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 0ba94740333f809189eafa56aec07388 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 Feb 2012 19:11:25 -0000\r
+\r
+\r
+On Sat, 04 Feb 2012 20:03:13 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> On Sat, 4 Feb 2012 17:09:10 +0000, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> > This patch uses the new --from option to notmuch reply to allow it to\r
+> > prompt the user for the From: address in cases when the cli does not\r
+> > know the "correct" from address. If the cli does not it either uses\r
+> > the users default address or, if notmuch-always-prompt-for-sender\r
+> > is set, prompts the user.\r
+> > ---\r
+> > emacs/notmuch-mua.el | 47 ++++++++++++++++++++++++++++-------------------\r
+> > 1 files changed, 28 insertions(+), 19 deletions(-)\r
+> > \r
+> > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el\r
+> > index 41f82c2..36e62f9 100644\r
+> > --- a/emacs/notmuch-mua.el\r
+> > +++ b/emacs/notmuch-mua.el\r
+> > @@ -51,6 +51,24 @@ list."\r
+> > \r
+> > ;;\r
+> > \r
+> > +(defcustom notmuch-identities nil\r
+> > + "Identities that can be used as the From: address when composing a new message.\r
+> > +\r
+> > +If this variable is left unset, then a list will be constructed from the\r
+> > +name and addresses configured in the notmuch configuration file."\r
+> > + :type '(repeat string)\r
+> > + :group 'notmuch-send)\r
+> > +\r
+> > +(defcustom notmuch-always-prompt-for-sender nil\r
+> > + "Always prompt for the From: address when composing or forwarding a message.\r
+> > +\r
+> > +This is not taken into account when replying to a message, because in that case\r
+> > +the From: header is already filled in by notmuch."\r
+> > + :type 'boolean\r
+> > + :group 'notmuch-send)\r
+> > +\r
+> > +(defvar notmuch-mua-sender-history nil)\r
+> > +\r
+> > (defun notmuch-mua-user-agent-full ()\r
+> > "Generate a `User-Agent:' string suitable for notmuch."\r
+> > (concat (notmuch-mua-user-agent-notmuch)\r
+> > @@ -75,7 +93,7 @@ list."\r
+> > (defun notmuch-mua-reply (query-string &optional sender reply-all)\r
+> > (let (headers\r
+> > body\r
+> > - (args '("reply")))\r
+> > + (args '("reply" "--from=fallback-received")))\r
+> \r
+> There are better reviewers for the rest of the emacs bits, but wouldn't\r
+> it be better to just use the "notmuch reply" default when the user wants\r
+> the current behaviour?\r
+\r
+Does any user actually want to be prompted for a From address when\r
+mailing/forwarding normally but not when replying and there is no reason\r
+to choose one address over another?\r
+\r
+What I would actually like is to consolidate the From address choosing\r
+so that it occurs in one place in the emacs code, so the three\r
+(mail/forward/reply) naturally behave the same.\r
+\r
+Thanks for the rapid review (and the significant bug catch!)\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+> BR,\r
+> Jani.\r
+> \r
+> \r
+> > (if notmuch-show-process-crypto\r
+> > (setq args (append args '("--decrypt"))))\r
+> > (if reply-all\r
+> > @@ -99,6 +117,15 @@ list."\r
+> > ;; If sender is non-nil, set the From: header to its value.\r
+> > (when sender\r
+> > (mail-header-set 'from sender headers))\r
+> > + ;; If we do not have a From: header yet it means that\r
+> > + ;; notmuch-reply.c was not able to make a useful guess so we fill\r
+> > + ;; it in ourselves.\r
+> > + (when (string= "" (mail-header 'from headers))\r
+> > + (if notmuch-always-prompt-for-sender\r
+> > + (setq sender (notmuch-mua-prompt-for-sender))\r
+> > + (setq sender (concat\r
+> > + (notmuch-user-name) " <" (notmuch-user-primary-email) ">")))\r
+> > + (mail-header-set 'from sender headers))\r
+> > (let\r
+> > ;; Overlay the composition window on that being used to read\r
+> > ;; the original message.\r
+> > @@ -153,24 +180,6 @@ OTHER-ARGS are passed through to `message-mail'."\r
+> > \r
+> > (message-goto-to))\r
+> > \r
+> > -(defcustom notmuch-identities nil\r
+> > - "Identities that can be used as the From: address when composing a new message.\r
+> > -\r
+> > -If this variable is left unset, then a list will be constructed from the\r
+> > -name and addresses configured in the notmuch configuration file."\r
+> > - :type '(repeat string)\r
+> > - :group 'notmuch-send)\r
+> > -\r
+> > -(defcustom notmuch-always-prompt-for-sender nil\r
+> > - "Always prompt for the From: address when composing or forwarding a message.\r
+> > -\r
+> > -This is not taken into account when replying to a message, because in that case\r
+> > -the From: header is already filled in by notmuch."\r
+> > - :type 'boolean\r
+> > - :group 'notmuch-send)\r
+> > -\r
+> > -(defvar notmuch-mua-sender-history nil)\r
+> > -\r
+> > (defun notmuch-mua-prompt-for-sender ()\r
+> > (interactive)\r
+> > (let (name addresses one-name-only)\r
+> > -- \r
+> > 1.7.2.3\r
+> > \r
+> > _______________________________________________\r
+> > notmuch mailing list\r
+> > notmuch@notmuchmail.org\r
+> > http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff