Re: [PATCH 01/13] test: Uniformly canonicalize actual and expected JSON

diff --git a/4d/e57156ed8555841ab40f460be242ea101a0e7f b/4d/e57156ed8555841ab40f460be242ea101a0e7f
new file mode 100644 (file)
index 0000000..8e78d6f
--- /dev/null
+++ b/4d/e57156ed8555841ab40f460be242ea101a0e7f
@@ -0,0 +1,77 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 63F4D431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 25 Jul 2012 20:24:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id j0YDdqq8+JuD for <notmuch@notmuchmail.org>;\r
+       Wed, 25 Jul 2012 20:24:47 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id B68C7431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 25 Jul 2012 20:24:47 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 4227E10014E; Thu, 26 Jul 2012 06:24:58 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 01/13] test: Uniformly canonicalize actual and expected\r
+       JSON\r
+In-Reply-To: <1343183693-17134-2-git-send-email-amdragon@mit.edu>\r
+References: <1343183693-17134-1-git-send-email-amdragon@mit.edu>\r
+       <1343183693-17134-2-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.13.2+103~g9610d35 (http://notmuchmail.org) Emacs/23.1.1\r
+       (x86_64-redhat-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 26 Jul 2012 06:24:58 +0300\r
+Message-ID: <m2629bcigl.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 26 Jul 2012 03:24:48 -0000\r
+\r
+On Wed, Jul 25 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Previously, we used a variety of ad-hoc canonicalizations for JSON\r
+> output in the test suite, but were ultimately very sensitive to JSON\r
+> irrelevancies such as whitespace.  This introduces a new test\r
+> comparison function, test_expect_equal_json, that first pretty-prints\r
+> *both* the actual and expected JSON and the compares the result.\r
+>\r
+> The current implementation of this simply uses Python's json.tool to\r
+> perform pretty-printing (with a fallback to the identity function if\r
+> parsing fails).  However, since the interface it introduces is\r
+> semantically high-level, we could swap in other mechanisms in the\r
+> future, such as another pretty-printer or something that does not\r
+> re-order object keys (if we decide that we care about that).\r
+\r
+\r
+The whole series looks good to me and was easy to read through.\r
+The use of Python json.tool is pretty reasonable; It is shipped in\r
+Python 2.6+ (For example perl does not ship json components by default,\r
+making it more complicated to set up for this purpose). If that is too\r
+"much", then we could also use tr -d '[:space:]' as an intermediate\r
+solution (but that eats whitespace in quoted content too...)\r
+\r
+I'll be afk for a few days then I test this... \r
+\r
+Tomi\r