Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equa...

diff --git a/ea/466ca4ecfe185a0cb91464bacf3b89c54aadd0 b/ea/466ca4ecfe185a0cb91464bacf3b89c54aadd0
new file mode 100644 (file)
index 0000000..e8eb717
--- /dev/null
+++ b/ea/466ca4ecfe185a0cb91464bacf3b89c54aadd0
@@ -0,0 +1,90 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9405B431FBD\r
+       for <notmuch@notmuchmail.org>; Thu,  2 Feb 2012 10:01:03 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2UdnI+21-DsR for <notmuch@notmuchmail.org>;\r
+       Thu,  2 Feb 2012 10:01:03 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 41C9E431FAF\r
+       for <notmuch@notmuchmail.org>; Thu,  2 Feb 2012 10:01:03 -0800 (PST)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id DF9CD66E01C8;\r
+       Thu,  2 Feb 2012 10:01:02 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com\r
+       [76.174.137.84]) (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 3027E66E0170;\r
+       Thu,  2 Feb 2012 10:01:00 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id E3BD4291; Thu,  2 Feb 2012 10:00:59 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for\r
+       test_expect_equal_file\r
+In-Reply-To: <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com>\r
+User-Agent: Notmuch/0.11+128~g6f388fa (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 02 Feb 2012 10:00:59 -0800\r
+Message-ID: <87zkd1p12c.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 02 Feb 2012 18:01:03 -0000\r
+\r
+--=-=-=\r
+\r
+Hey, Dmitry.  I'm so sorry I sent my last email on your original patch\r
+before I saw this new series.  I do now like your original proposal\r
+better, since it shows the diff based the names the caller provides,\r
+which I now agree is probably the clearest and most robust solution.\r
+The second patch in this series could still go through, though, no\r
+matter what version of the change to test_expect_equal_file we go with.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPKs9bAAoJEO00zqvie6q8KugP/0VGzl0vuFaCMSHtJyvCKzOV\r
+M3qmgW4viMyTov4NYj/EtdAnRbq0pYkhu2+waCjVZ/CMLK7dCIa9NDI2WznMah8R\r
+Y4Kl5KlvxTA2cFSvJQJ+HRkFINDiYutjCnWzuqO3oBVWjYf8LcLiP4dZht5+mDRR\r
+rrsTd3EKIRXV3pXCM8a/nJFqznNRevKc/wn6r3SK517w5+S/6131iBurppl16nUd\r
+t7pi5CVxcBTHBzYyveC5fmIvAbmMe/loDQSVlp8wWbpO9OGUzq8HmqhRXDalNwDV\r
+hrGnW4dHpmduvYil8IcJKBzAX5hOm4avt/7UAfl9dhVA1V+fNBr+nxF2XR7nhtZf\r
+e4IldaVS+tD3hy7NPlwevNz8VM81m/07GYCjWcIg1f50iKb6MvwuNakz4dPmJ4UH\r
+vKjWAYwEjwHTrXd4Im/6DcoAa3Jc7/A0CMadGajfij20UONUjSGJWEs5lu9787pz\r
+3C6YdwrrSexUa3e+OQ2an0kVK3HIUHsg/ltO5CG3Sf7dQHoOeEej9+ynilWXiYtk\r
+MXgBxmKHFq2trfSGfoE2vndp86rKSNzoASF81jm3Mdy5nf3F+z1VKkitmftnTBzG\r
+xnWRUGYMWGHyM1PMWMl1I1RWm8s8ZTzDn1bf4JnJj2RjO41tZYWvj3GJR/v5x2Co\r
+z96o+Gn6LmW1PisBXfNN\r
+=jTqi\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r