Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by default

diff --git a/7c/6d71a18ae8c44cab57caec24bcad675e66babd b/7c/6d71a18ae8c44cab57caec24bcad675e66babd
new file mode 100644 (file)
index 0000000..b6eda49
--- /dev/null
+++ b/7c/6d71a18ae8c44cab57caec24bcad675e66babd
@@ -0,0 +1,112 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 23672431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 10:05:23 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id WCF-W-tmiGg1 for <notmuch@notmuchmail.org>;\r
+       Sun, 19 Feb 2012 10:05:22 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
+       [18.9.25.13])\r
+       by olra.theworths.org (Postfix) with ESMTP id A445D431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 10:05:22 -0800 (PST)\r
+X-AuditID: 1209190d-b7fbf6d0000008ba-eb-4f4139e28851\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 1F.07.02234.2E9314F4; Sun, 19 Feb 2012 13:05:22 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q1JI5LVX020545; \r
+       Sun, 19 Feb 2012 13:05:22 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q1JI5KN8013954\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Sun, 19 Feb 2012 13:05:20 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1RzB6f-0007Xa-Lu; Sun, 19 Feb 2012 13:03:29 -0500\r
+Date: Sun, 19 Feb 2012 13:03:29 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by\r
+ default\r
+Message-ID: <20120219180329.GR5991@mit.edu>\r
+References: <1329632533-16152-1-git-send-email-amdragon@mit.edu>\r
+       <m2k43jw43j.fsf@guru.guru-group.fi> <20120219172541.GQ5991@mit.edu>\r
+       <87zkceloiz.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87zkceloiz.fsf@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsUixCmqrPvI0tHfYMUJLourW/vZLa7fnMls\r
+       8WblPFYHZo+ds+6yexz+upDF49mqW8wBzFFcNimpOZllqUX6dglcGWe3LWUtuMddsWrCDpYG\r
+       xkmcXYycHBICJhLTFx9hh7DFJC7cW8/WxcjFISSwj1Hi8//HjBDOBkaJhol/2CGck0wSB3bv\r
+       ZoVwljBKPJkymxWkn0VAVaLv134wm01AQ2Lb/uWMILaIgKHErYuvmLsYOTiYBWwlpl6JAQkL\r
+       CwRKzHs/BWw1r4C2xNHDr6EWLGWUWHt7BytEQlDi5MwnLCA2s4CWxI1/L5kg5khLLP/HARLm\r
+       FFCX+PfhIRuILSqgIjHl5Da2CYxCs5B0z0LSPQuhewEj8ypG2ZTcKt3cxMyc4tRk3eLkxLy8\r
+       1CJdI73czBK91JTSTYzgYJfk3cH47qDSIUYBDkYlHl7JMgd/IdbEsuLK3EOMkhxMSqK8POaO\r
+       /kJ8SfkplRmJxRnxRaU5qcWHGCU4mJVEeEtv2vsL8aYkVlalFuXDpKQ5WJTEeVW13vkJCaQn\r
+       lqRmp6YWpBbBZGU4OJQkeGOBUS0kWJSanlqRlplTgpBm4uAEGc4DNFwUpIa3uCAxtzgzHSJ/\r
+       ilGX4+OBJxcYhVjy8vNSpcR5vUCKBECKMkrz4ObAktQrRnGgt4R540CqeIAJDm7SK6AlTEBL\r
+       eIXsQJaUJCKkpBoY5WZJFb3Y1mrB/qfIUTvJQCr7v+nhIv6Hvzj+M5/SdD/+f57ztZ7PdWZe\r
+       oouL/83a7XXHpfrC8VeXS1X61qxcqauTbGl119/nYFXcLlbx02t11ig/nVw289CW2etX+zId\r
+       3eYn7DPvW+q00AdcWyLXL13aHvvQ+O0Rs9tuoi6GTPkzjt5dW+X6UImlOCPRUIu5qDgRAKpm\r
+       FtktAwAA\r
+Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 19 Feb 2012 18:05:23 -0000\r
+\r
+Quoth Dmitry Kurochkin on Feb 19 at  9:29 pm:\r
+> On Sun, 19 Feb 2012 12:25:41 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > Quoth Tomi Ollila on Feb 19 at 11:43 am:\r
+> > > On Sun, 19 Feb 2012 01:22:10 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > > > Based on the thread at id:"20120213152858.GO27039@mit.edu" it seems\r
+> > > > like people want show refresh to retain message state by default (I\r
+> > > > certainly do), rather than reset it by default.  As a nice bonus, this\r
+> > > > fixes a broken test.\r
+> > > \r
+> > > Hmm\r
+> > > \r
+> > > Every '=' keypress in a thread removes 'unread' tag from next unread \r
+> > > message :o\r
+> > \r
+> > Oh dear.  It's slightly subtler than that, though.  Refreshing will\r
+> > remove the unread tag from the first message matching the query.  (I\r
+> > suspect you had tag:unread in your query?)  This is particularly\r
+> > confusing for state-retaining refresh because that message might not\r
+> > even be open.\r
+> > \r
+> > > That is probably desirable feature when refreshing view without\r
+> > > retaining state. Also, probably notmuch-show-refresh-view should\r
+> > > be fixed not to mark next message unread when retaining state ?\r
+> > \r
+> > I would argue that refresh should never have side-effects, so neither\r
+> > case should mark anything read.  I'll send a v2.\r
+> \r
+> I agree.  But this looks like a separate issue, no?  So why v2 instead\r
+> of a separate patch/series?\r
+\r
+I wanted to slip it in before inverting the default behavior of\r
+refresh.\r