Re: [PATCH 3/4] emacs: possibility to customize the rendering of tags

diff --git a/74/a910db2e610f1c1ab05d627f5f190b563adb91 b/74/a910db2e610f1c1ab05d627f5f190b563adb91
new file mode 100644 (file)
index 0000000..a5277d2
--- /dev/null
+++ b/74/a910db2e610f1c1ab05d627f5f190b563adb91
@@ -0,0 +1,108 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3A548431FC4\r
+       for <notmuch@notmuchmail.org>; Tue, 22 Jan 2013 18:15:54 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id nX94-MfnY3Kc for <notmuch@notmuchmail.org>;\r
+       Tue, 22 Jan 2013 18:15:53 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 44FDF431FC0\r
+       for <notmuch@notmuchmail.org>; Tue, 22 Jan 2013 18:15:53 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 889C3100086;\r
+       Wed, 23 Jan 2013 04:15:42 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>,\r
+ Damien Cassou <damien.cassou@gmail.com>,\r
+       notmuch mailing list <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 3/4] emacs: possibility to customize the rendering of tags\r
+In-Reply-To: <87mww0da71.fsf@awakening.csail.mit.edu>\r
+References: <1358525039-13569-1-git-send-email-damien.cassou@gmail.com>\r
+       <1358525039-13569-4-git-send-email-damien.cassou@gmail.com>\r
+       <87mww0da71.fsf@awakening.csail.mit.edu>\r
+User-Agent: Notmuch/0.15+11~ge1e719d (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 23 Jan 2013 04:15:42 +0200\r
+Message-ID: <m24ni8hcfl.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 23 Jan 2013 02:15:54 -0000\r
+\r
+On Wed, Jan 23 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> On Fri, 18 Jan 2013, Damien Cassou <damien.cassou@gmail.com> wrote:\r
+>\r
+>> +  `(("unread"\r
+>> +     (:propertize "unread" face\r
+>> +                  (:Foreground "red")))\r
+>> +    ("flagged"\r
+>> +     (:propertize "flagged" display\r
+>> +                  (image :type svg :file\r
+>> +                         ,(expand-file-name\r
+>> +                           "resources/star.svg"\r
+>> +                           (file-name-directory\r
+>> +                            (or\r
+>> +                             (locate-library "notmuch-tagger")\r
+>> +                             (buffer-file-name))))\r
+>\r
+> Interesting.  Is this a standard way to locate resources?  (I've never\r
+> had need to.)\r
+>\r
+> Since there are other icons here as well, perhaps the resources\r
+> directory should be bound to a global variable so it's easy to construct\r
+> other standard notmuch icon names?  You capture this in a function in\r
+> patch 4, but that function doesn't obviously accomplish anything a\r
+> simple variable wouldn't.\r
+\r
+I was thinking this too. M-x apropos RET -path RET (apropos "-path")\r
+outputs (at least) 2 symbols that are relevant here:\r
+\r
+image-load-path\r
+  Variable: List of locations in which to search for image files.\r
+  Properties: standard-value custom-type custom-requests\r
+              variable-documentation\r
+and\r
+\r
+image-load-path-for-library\r
+  Function: Return a suitable search path for images used by LIBRARY.\r
+\r
+(if the second were used I'd suggest to use 'notmuch' instead of\r
+'notmuch-tagger' -- just to support me who just installs notmuch.elc\r
+which is done by concatenating all notmuch .el files together to one\r
+notmuch.el file which is then byte-compiled :D)\r
+\r
+> Another possibility is that these icons could be included directly in\r
+> the Elisp source, probably as simplified SVGs (your SVGs look like they\r
+> could be cut down to 3 or 4 lines of XML easily) or as XPMs.  Besides\r
+> skirting issues with resource location, this would make it trivial to\r
+> alter their colors based on user preferences.\r
+\r
+I also had the same 2 things in mind, simplify SVGs and possibly include\r
+that directly in the source...\r
+\r
+\r
+Tomi\r