Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)

diff --git a/a2/6a5c7ff4cb8a0296b8830476fcbe0e38d901e5 b/a2/6a5c7ff4cb8a0296b8830476fcbe0e38d901e5
new file mode 100644 (file)
index 0000000..cb89da1
--- /dev/null
+++ b/a2/6a5c7ff4cb8a0296b8830476fcbe0e38d901e5
@@ -0,0 +1,111 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C8585431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  6 Apr 2012 08:38:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.401\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.401 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id AxxN-3h5Rfj6 for <notmuch@notmuchmail.org>;\r
+       Fri,  6 Apr 2012 08:38:16 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 270E3431FAE\r
+       for <notmuch@notmuchmail.org>; Fri,  6 Apr 2012 08:38:15 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1SGBEo-0001sI-Pj; Fri, 06 Apr 2012 16:38:11 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+       helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1SGBEo-0000iY-FH; Fri, 06 Apr 2012 16:38:10 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)\r
+In-Reply-To: <87bon47v0o.fsf@servo.finestructure.net>\r
+References: <1333716551-29153-1-git-send-email-markwalters1009@gmail.com>\r
+       <87bon47v0o.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.12+96~g8f5ec3b (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 06 Apr 2012 16:38:20 +0100\r
+Message-ID: <87ty0w50r7.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 1e624825d6275d7cbb637cd4d1746cd9 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.2\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.2 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  1.0 FREEMAIL_REPLY From and body contain different freemails\r
+       *  0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 06 Apr 2012 15:38:18 -0000\r
+\r
+On Fri, 06 Apr 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> On Fri, Apr 06 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+>> This is the latest version of the patch series (previous version at [1]).\r
+>> I think this version fixes all the problems raised by Austin in his review.\r
+>\r
+> Tested and reviewed and LGTM.\r
+>\r
+> Unfortunately, though, I just now noticed that the tests don't cover\r
+> count and show excludes.  Since everything else looks good, let's just\r
+> make a new version of [0].  I suggest we name the new test script just\r
+> "excludes" and then add count and show tests there.  That should be\r
+> pretty straightforward.\r
+\r
+There are some exclude tests for count in test/count. Do you think it\r
+needs to be a full test everything like in test/search-exclude?\r
+\r
+There aren't any tests for show exclude, but there aren't very many\r
+tests explicitly for show anyway. My preference would be to add\r
+something like\r
+id:"1332171061-27983-1-git-send-email-markwalters1009@gmail.com" and add\r
+some tests to that. I could add some tests for show-excludes in the same format\r
+as the search-exclude tests though if you think that is better.\r
+\r
+Best wishes\r
+\r
+Mark\r
+>\r
+> Thanks again, Mark.\r
+>\r
+> jamie.\r
+>\r
+> [0] id:"1333716551-29153-5-git-send-email-markwalters1009@gmail.com"\r