Re: [PATCH] contrib: pick: bugfix when trying to show a non-message

diff --git a/45/11c6a86eaaf8434320b0255d086c5a3f6bfeda b/45/11c6a86eaaf8434320b0255d086c5a3f6bfeda
new file mode 100644 (file)
index 0000000..40a8239
--- /dev/null
+++ b/45/11c6a86eaaf8434320b0255d086c5a3f6bfeda
@@ -0,0 +1,74 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B9C4F431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  9 Nov 2012 00:55:58 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id JMmUxet-W6UF for <notmuch@notmuchmail.org>;\r
+       Fri,  9 Nov 2012 00:55:56 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id E576E431FAE\r
+       for <notmuch@notmuchmail.org>; Fri,  9 Nov 2012 00:55:55 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 98B89100094;\r
+       Fri,  9 Nov 2012 10:55:54 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>,\r
+ Mark Walters <markwalters1009@gmail.com>,     notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] contrib: pick: bugfix when trying to show a non-message\r
+In-Reply-To: <87ehk332la.fsf@zancas.localnet>\r
+References: <1351797983-19707-1-git-send-email-markwalters1009@gmail.com>\r
+       <87ehk332la.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Fri, 09 Nov 2012 10:55:54 +0200\r
+Message-ID: <m2fw4jqhnp.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 09 Nov 2012 08:55:58 -0000\r
+\r
+On Fri, Nov 09 2012, David Bremner <david@tethera.net> wrote:\r
+\r
+> Mark Walters <markwalters1009@gmail.com> writes:\r
+>\r
+>> -  (concat "id:\"" (notmuch-pick-get-prop :id) "\""))\r
+>> +  (let ((id (notmuch-pick-get-prop :id)))\r
+>> +    (when id\r
+>> +      (concat "id:\"" id "\""))))\r
+>\r
+> I don't know how other people feel, but I'd rather have an `if' in a\r
+> context where I care about the return value.\r
+\r
+Does (when COND BODY) connotate to the thought that the return value\r
+is generally not used ? That expands to (if COND (progn BODY)) so both\r
+returns exactly same values.\r
+\r
+(not that I wouldn't prefer if there :)\r
+\r
+But instead of this the function in question could use\r
+recently introduced (notmuch-id-to-query id) instead.\r
+\r
+Tomi\r