Re: [PATCH 3/4] lib: Only synchronize maildir flags for messages in maildirs

diff --git a/be/6502be8f4245b366f9c7d2d0577253144c78a9 b/be/6502be8f4245b366f9c7d2d0577253144c78a9
new file mode 100644 (file)
index 0000000..10a0c77
--- /dev/null
+++ b/be/6502be8f4245b366f9c7d2d0577253144c78a9
@@ -0,0 +1,110 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7E9EA431FB6\r
+       for <notmuch@notmuchmail.org>; Mon,  4 Jun 2012 00:02:04 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id SbCA59G43PmT for <notmuch@notmuchmail.org>;\r
+       Mon,  4 Jun 2012 00:02:03 -0700 (PDT)\r
+Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com\r
+       [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id DB5D3431FAF\r
+       for <notmuch@notmuchmail.org>; Mon,  4 Jun 2012 00:02:02 -0700 (PDT)\r
+Received: by vbbfc26 with SMTP id fc26so3919400vbb.26\r
+       for <notmuch@notmuchmail.org>; Mon, 04 Jun 2012 00:02:02 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type:x-gm-message-state;\r
+       bh=VkKljJxf22oxM1a9M2+k17c4w22D6txHOvs7YpqOLo4=;\r
+       b=S6FcH9KpdVExmccg+gCxrw/F5PX4fvUrxrn9+t3iWQuUdIz2c1je5ePxuPl70NHTxc\r
+       CY3KuQT0tPBFiF8c/iZP5qnlMktmK3BNC/ypfsjtPL+1QFHeAKyT6ZAhbp/BdbgKzq05\r
+       XLpEs+r5kb/lEaRu99VjrCl3Oo/bMUzwUhrJyH87jj9LT/ZFqmSg+Kr8MR3QW5lFFUIF\r
+       7LPbIaxNL//Hkekq+JwO5qPeyxMslAUPWdjir+vKg21fRRF/uAgRp1iVsjaNvUAteOIN\r
+       Iz4pjO5u2NZmdlRpn4Um+ce3DBQEnIXUDkRoppYQuhoNHRoC5YP2Yl4vYZncKhQnatpL\r
+       ngNQ==\r
+Received: by 10.220.242.14 with SMTP id lg14mr11220265vcb.28.1338793320988;\r
+       Mon, 04 Jun 2012 00:02:00 -0700 (PDT)\r
+Received: from localhost (nikula.org. [92.243.24.172])\r
+       by mx.google.com with ESMTPS id c17sm16068196vdj.11.2012.06.04.00.01.59\r
+       (version=SSLv3 cipher=OTHER); Mon, 04 Jun 2012 00:02:00 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/4] lib: Only synchronize maildir flags for messages in\r
+       maildirs\r
+In-Reply-To: <1338742656-11640-4-git-send-email-amdragon@mit.edu>\r
+References: <1338742656-11640-1-git-send-email-amdragon@mit.edu>\r
+       <1338742656-11640-4-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.13+9~ga1668d0 (http://notmuchmail.org) Emacs/23.1.1\r
+       (i686-pc-linux-gnu)\r
+Date: Mon, 04 Jun 2012 07:01:57 +0000\r
+Message-ID: <87pq9fr256.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQniR+siFPDuzzUwxiSzxIR/qAR0MKGHqc4hsYuHuaEmKxqe9qc2rw5TTFQRtXd0HnZRmL64\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 04 Jun 2012 07:02:04 -0000\r
+\r
+\r
+The patch makes a lot of sense, and fixes the asymmetry introduced by\r
+commit 95dd5fe5. I think it deserves a more verbose commit message,\r
+along with that commit reference, and (eventually, not necessarily in\r
+this series) a NEWS item of its own.\r
+\r
+On Sun, 03 Jun 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> ---\r
+>  lib/message.cc |    6 +++++-\r
+>  1 file changed, 5 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/lib/message.cc b/lib/message.cc\r
+> index ed96477..bbac2ff 100644\r
+> --- a/lib/message.cc\r
+> +++ b/lib/message.cc\r
+> @@ -1074,7 +1074,7 @@ notmuch_message_maildir_flags_to_tags (notmuch_message_t *message)\r
+>      const char *flags;\r
+>      notmuch_status_t status;\r
+>      notmuch_filenames_t *filenames;\r
+> -    const char *filename;\r
+> +    const char *filename, *dir;\r
+>      char *combined_flags = talloc_strdup (message, "");\r
+>      unsigned i;\r
+>      int seen_maildir_info = 0;\r
+> @@ -1084,6 +1084,10 @@ notmuch_message_maildir_flags_to_tags (notmuch_message_t *message)\r
+>       notmuch_filenames_move_to_next (filenames))\r
+>      {\r
+>      filename = notmuch_filenames_get (filenames);\r
+> +    dir = _filename_is_in_maildir (filename);\r
+> +\r
+> +    if (! dir)\r
+> +        continue;\r
+>  \r
+>      flags = strstr (filename, ":2,");\r
+>      if (! flags)\r
+> -- \r
+> 1.7.10\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r