--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 461BC431FBC\r
+ for <notmuch@notmuchmail.org>; Tue, 30 Oct 2012 07:44:39 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 2jLZSfkXpgXJ for <notmuch@notmuchmail.org>;\r
+ Tue, 30 Oct 2012 07:44:38 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id 56EE7431FAF\r
+ for <notmuch@notmuchmail.org>; Tue, 30 Oct 2012 07:44:38 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 2AB5E10007D;\r
+ Tue, 30 Oct 2012 16:44:38 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] contrib: notmuch-pick: add tests\r
+In-Reply-To: <1351499856-14136-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1351499856-14136-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.14+59~gf9031cd (http://notmuchmail.org) Emacs/24.2.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 30 Oct 2012 16:44:37 +0200\r
+Message-ID: <m2ip9srpd6.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/mixed; boundary="=-=-="\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 30 Oct 2012 14:44:39 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+\r
+On Mon, Oct 29 2012, Mark Walters wrote:\r
+\r
+> The test should be run using the wrapper test-wrapper.sh. This links\r
+> the tests into the normal notmuch TEST_DIRECTORY and runs them from\r
+> there. After the test is complete then the links are removed.\r
+> ---\r
+\r
+Looks pretty good. The emacs-pick has leading spaces and tabs mixed;\r
+you could run whitespace-cleanup on it.\r
+\r
+I got a bit irritated to your test-wrapper.sh so I experimented what\r
+could be done to make it a bit more robust. Look at the attachment\r
+for suggestions (i.e. use and reformat parts of it freely).\r
+\r
+Tomi\r
+\r
+\r
+--=-=-=\r
+Content-Type: application/x-sh\r
+Content-Disposition: inline; filename=test-wrapper.sh\r
+Content-Transfer-Encoding: base64\r
+Content-Description: notmuch pick contrib test wrapper suggestions\r
+\r
+IyEvYmluL3NoCgpzZXQgLWV1CgpmYWlsKCkgewoJZWNobyBFUlJPUiAkMQoJZXhpdCAxCn0KClRF\r
+U1RGSUxFUz0nZW1hY3MtcGljayBwaWNrLmV4cGVjdGVkLW91dHB1dCcKClBJQ0tfRElSPWBjZCBc\r
+YGRpcm5hbWUgIiQwIlxgICYmIHB3ZGAKCmZvciBmIGluICRURVNURklMRVMKZG8KCXRlc3QgLWYg\r
+IiRQSUNLX0RJUi8kZiIgfHwgZmFpbCAiJFBJQ0tfRElSLyRmIGRvZXMgbm90IGV4aXN0Igpkb25l\r
+CgpjZCAiJFBJQ0tfRElSLy4uLy4uL3Rlc3QiCgp0ZXN0IC14IC4uL25vdG11Y2ggfHwgZmFpbCAi\r
+YGNkIC4uICYmIHB3ZGAvbm90bXVjaCBoYXMgbm90IGJlZW4gYnVpbHQiCgpmb3IgZiBpbiAkVEVT\r
+VEZJTEVTCmRvCglpZiB0ZXN0IC1mICIkZiIKCXRoZW4KCQlmYWlsICIkZiBleGlzdHMiCglmaQpk\r
+b25lCgp0cmFwICJybSAtZiAkVEVTVEZJTEVTIiAwCgpmb3IgZiBpbiAkVEVTVEZJTEVTCmRvCgls\r
+biAtcyAiJFBJQ0tfRElSLyRmIiAuCmRvbmUKCiNkb24ndCBleGVjIC0tIHRyYXBzIHdvdWxkIG5v\r
+dCBydW4uCi4vZW1hY3MtcGljawo=\r
+--=-=-=\r
+Content-Type: text/plain\r
+\r
+\r
+\r
+>\r
+> Here are some tests for notmuch-pick. I would have liked to include\r
+> the test structure and run them from inside the pick contrib directory\r
+> but I couldn't get all the paths to work.\r
+>\r
+> Hence, this slightly hacky solution of linking the relevant stuff (one\r
+> test script and one expected output directory) into the normal notmuch\r
+> test directory and running from there. \r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+> contrib/notmuch-pick/README | 5 +\r
+> contrib/notmuch-pick/test-wrapper.sh | 16 +++\r
+> contrib/notmuch-pick/test/emacs-pick | 104 ++++++++++++++++++++\r
+> .../notmuch-pick-single-thread | 6 +\r
+> .../pick.expected-output/notmuch-pick-tag-inbox | 53 ++++++++++\r
+> 5 files changed, 184 insertions(+), 0 deletions(-)\r
+> create mode 100755 contrib/notmuch-pick/test-wrapper.sh\r
+> create mode 100755 contrib/notmuch-pick/test/emacs-pick\r
+> create mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-single-thread\r
+> create mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-tag-inbox\r
+\r
+--=-=-=--\r