Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag
authorAustin Clements <amdragon@MIT.EDU>
Tue, 31 Jan 2012 05:08:10 +0000 (00:08 +1900)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:43:46 +0000 (09:43 -0800)
c5/1ba2f3b3dc6d514dbd4210b04bce45d0addc90 [new file with mode: 0644]

diff --git a/c5/1ba2f3b3dc6d514dbd4210b04bce45d0addc90 b/c5/1ba2f3b3dc6d514dbd4210b04bce45d0addc90
new file mode 100644 (file)
index 0000000..3a7f499
--- /dev/null
@@ -0,0 +1,116 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 258A341ED96\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 21:09:04 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id b+Ed63FZiefN for <notmuch@notmuchmail.org>;\r
+       Mon, 30 Jan 2012 21:09:03 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU\r
+       [18.7.68.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id 95D2141ED91\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 21:09:03 -0800 (PST)\r
+X-AuditID: 12074424-b7fae6d000000906-15-4f27776f308d\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 3D.7A.02310.F67772F4; Tue, 31 Jan 2012 00:09:03 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q0V593Uf030148; \r
+       Tue, 31 Jan 2012 00:09:03 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0V5917O004147\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Tue, 31 Jan 2012 00:09:02 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@MIT.EDU>)\r
+       id 1Rs5ww-0002pT-Ai; Tue, 31 Jan 2012 00:08:10 -0500\r
+Date: Tue, 31 Jan 2012 00:08:10 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag\r
+Message-ID: <20120131050810.GC17991@mit.edu>\r
+References: <20120124011609.GX16740@mit.edu>\r
+       <1327367923-18228-2-git-send-email-markwalters1009@gmail.com>\r
+       <20120124024521.GY16740@mit.edu> <874nvg6qxn.fsf@qmul.ac.uk>\r
+       <20120128183340.GD17991@mit.edu> <8739azqt2j.fsf@qmul.ac.uk>\r
+       <87zkd6pzg2.fsf@qmul.ac.uk> <8762fu4aqt.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <8762fu4aqt.fsf@qmul.ac.uk>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hRV1s0vV/c3uHCL12L1XB6L6zdnMjsw\r
+       eeycdZfd49mqW8wBTFFcNimpOZllqUX6dglcGV+PtbAXbOSuWPXiM2sD4xWOLkZODgkBE4kt\r
+       J3oYIWwxiQv31rN1MXJxCAnsY5TYcP8dI4SzgVHi0Pa1LBDOSSaJ9f/3MIO0CAksYZR4/JUb\r
+       xGYRUJX4fPYZE4jNJqAhsW3/crCxIgI6ErcPLWAHsZkFpCW+/W4GqxEWcJZ43vSVFcTmBaqZ\r
+       3XiMBWLmKiaJ6a/EIOKCEidnPmGB6NWSuPHvJVAvB9ic5f/APuAEWjVr3muwkaICKhJTTm5j\r
+       m8AoNAtJ9ywk3bMQuhcwMq9ilE3JrdLNTczMKU5N1i1OTszLSy3SNdfLzSzRS00p3cQICmp2\r
+       F5UdjM2HlA4xCnAwKvHwCn1S8xdiTSwrrsw9xCjJwaQkyjunQN1fiC8pP6UyI7E4I76oNCe1\r
+       +BCjBAezkgjvm9VA5bwpiZVVqUX5MClpDhYlcV4NrXd+QgLpiSWp2ampBalFMFkZDg4lCd7m\r
+       MqChgkWp6akVaZk5JQhpJg5OkOE8QMNrQWp4iwsSc4sz0yHypxgVpcR540ESAiCJjNI8uF5Y\r
+       0nnFKA70ijDvLJAqHmDCgut+BTSYCWjwcwZVkMEliQgpqQbGzobT29mt82fGfNsh+OXdpucz\r
+       i/eeiS90OLM4oYZ3ihnDoX/9rFc8Ve7zZ0z5PrcmSuqb2urFuV8esF0uP8U74cRsOUPvXiYt\r
+       jS0qP5OOJEdefh62g81sfsoCtXOSi67MiTwXtcxk1gH2VTktK1t66k4FxNjcPtdevsjmX2LT\r
+       8k7728srEnjvKbEUZyQaajEXFScCAKZ61OkVAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 31 Jan 2012 05:09:04 -0000\r
+\r
+This is looking really good.  I think this overall approach is\r
+significantly better than the initial exclude support and the UI\r
+aspects look like they should be much more pleasant.\r
+\r
+Quoth Mark Walters on Jan 29 at  6:36 pm:\r
+> \r
+> Ok I now have a patch set which might be complete enough to be worth\r
+> reviewing. It is essentially complete and appears to work.\r
+> \r
+> Things that still need doing: \r
+>        updating the test suite. The series changes notmuch-show to\r
+>        output the exclude flag so several tests need updating. Of\r
+>        course, the new functionality needs some tests too.\r
+>        \r
+>        emacs/notmuch.el I think it would be nice to hide (make\r
+>        invisible) threads with no matching non-excluded messages (with a\r
+>        toggle for visibility) but that is definitely beyond my elisp\r
+>        skills.\r
+\r
+I'm happy to do that once this goes in.\r
+\r
+> The first patch of the series is not really part of the series: it adds\r
+> a --do-not-exclude option to tell the command not to exclude. I think\r
+> this is useful anyway, but it also simplifies behaviour decisions with\r
+> the excludes. For example notmuch count will only count matching\r
+> non-excluded messages but notmuch count --do-not-exclude will count \r
+> all matching messages excluded or not.\r
+> \r
+> One outstanding issue is that raised in\r
+> id:"20120124025331.GZ16740@mit.edu". I will need to think about\r
+> that. \r
+> \r
+> Best wishes\r
+> \r
+> Mark\r
+> \r