Re: [PATCH] emacs: show: make id links respect window
authorDavid Bremner <david@tethera.net>
Mon, 24 Dec 2012 15:54:35 +0000 (11:54 +2000)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:52:42 +0000 (09:52 -0800)
a8/4b5cb3e279b90bca2dd3a46292ba261f8633da [new file with mode: 0644]

diff --git a/a8/4b5cb3e279b90bca2dd3a46292ba261f8633da b/a8/4b5cb3e279b90bca2dd3a46292ba261f8633da
new file mode 100644 (file)
index 0000000..5ff5ffe
--- /dev/null
@@ -0,0 +1,73 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EF823431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Dec 2012 07:54:42 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id iJAuAI3W+faD for <notmuch@notmuchmail.org>;\r
+       Mon, 24 Dec 2012 07:54:42 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 566E6431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Dec 2012 07:54:42 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TnAMT-0000XG-6T; Mon, 24 Dec 2012 11:54:41 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TnAMN-0003Et-78; Mon, 24 Dec 2012 11:54:35 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: show: make id links respect window\r
+In-Reply-To: <1355958602-16752-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1355958602-16752-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 24 Dec 2012 11:54:35 -0400\r
+Message-ID: <87bodjfnt0.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 24 Dec 2012 15:54:43 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> I think this is a bug but that could be debated. It is particularly\r
+> easy to trigger with notmuch pick because that uses the split pane\r
+> while focus usually remains in the `pick' pane rather than the `show'\r
+> pane.\r
+\r
+I can imagine that people would want/like the "open in other window" \r
+effect of the current code, even if the reason is a bug.\r
+\r
+>                        'action `(lambda (arg)\r
+>                                   (notmuch-show ,(third link)))\r
+\r
+Can you (or someone) explain why backquote is needed here? Is this some\r
+kind of workaround for lack of lexical scope? If so, maybe a comment.\r
+\r
+d\r