Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equa...

diff --git a/50/86a3bd72ec7c28cac773c042b0a6d70f84a06a b/50/86a3bd72ec7c28cac773c042b0a6d70f84a06a
new file mode 100644 (file)
index 0000000..637dbc5
--- /dev/null
+++ b/50/86a3bd72ec7c28cac773c042b0a6d70f84a06a
@@ -0,0 +1,81 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id CB3FE431FAF\r
+       for <notmuch@notmuchmail.org>; Fri, 12 Oct 2012 10:42:32 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id U7AYlY3on-DD for <notmuch@notmuchmail.org>;\r
+       Fri, 12 Oct 2012 10:42:31 -0700 (PDT)\r
+Received: from mail-qa0-f46.google.com (mail-qa0-f46.google.com\r
+       [209.85.216.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 6F561431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 12 Oct 2012 10:42:31 -0700 (PDT)\r
+Received: by mail-qa0-f46.google.com with SMTP id c26so40377qad.5\r
+       for <notmuch@notmuchmail.org>; Fri, 12 Oct 2012 10:42:30 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=EhGslp7umPuYTfJkJtriZZqu1U8t8JTtefDgOk55fzs=;\r
+       b=moLWJpjnO9QFU31iazDN6zm8R6TcAbIIj1iibNEy/5A9OEfpNWaEovHW+8p9vpQyyk\r
+       UnewJYtl+ez62drwuzh4Pr9OPlcpHAbROZerRZTNgZrf3GvVN/KH/GQmeHAREcPI9JvU\r
+       7Q6DGYqLjT4MeyqbE2osPqFbEIMqG1kyzrXxblVqwtnczaPtaT9RYq0AauqlMVG/M8wN\r
+       OkwyBMTDruJhBbp/ymIGKjkUdsGFYMB9lfid6OC+6XQY61RT1Hb4B19njmsm9Z/Jkw3X\r
+       AfVoU32h044p3E5u2WeNg6fLOIQtrIt66h/v17a9zdJyKaoWSvBjxdt96+9K2DYPuN0s\r
+       HAPQ==\r
+Received: by 10.49.72.1 with SMTP id z1mr3629350qeu.2.1350063750838;\r
+       Fri, 12 Oct 2012 10:42:30 -0700 (PDT)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+       by mx.google.com with ESMTPS id z9sm6924340qeg.9.2012.10.12.10.42.29\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Fri, 12 Oct 2012 10:42:29 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,\r
+       Jameson Graef Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for\r
+       test_expect_equal_file\r
+In-Reply-To: <87sjishv3e.fsf@gmail.com>\r
+References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87zkd1p12c.fsf@servo.finestructure.net> <87sjishv3e.fsf@gmail.com>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 12 Oct 2012 13:42:24 -0400\r
+Message-ID: <87vcefa8ov.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 12 Oct 2012 17:42:32 -0000\r
+\r
+Dmitry Kurochkin <dmitry.kurochkin@gmail.com> writes:\r
+\r
+> Actually, we can do both: check file name for consistent diff order\r
+> (from expected to actual) and use file names that the caller provides.\r
+\r
+Hi! Reviewing the patch queue a little bit here. It seems like this\r
+patch ended up getting dropped because the other approach (using the\r
+filenames that the caller provided) won out and was even pushed. I'm\r
+therefore marking this series notmuch::obsolete (and also\r
+notmuch::stale since it doesn't apply cleanly).\r
+\r
+Ethan\r