perl-module.eclass: Fix GENTOO_DEPEND_ON_SUBSLOT handling/error
authorKent Fredric <kentnl@gentoo.org>
Fri, 21 Apr 2017 19:05:00 +0000 (07:05 +1200)
committerKent Fredric <kentnl@gentoo.org>
Fri, 21 Apr 2017 21:31:01 +0000 (09:31 +1200)
Currently errors even when set to "yes" ( which is the mechanics
that is implied if the option is missing )

This prematurely tells people about non-issues, and encourages
them to set the wrong value.

eclass/perl-module.eclass

index af5a0c9e34466b70f2d9dd713d8fd4b2eff361c7..a012b16dce922eb7f725d769cc104054b65a3004 100644 (file)
@@ -85,8 +85,8 @@ case ${EAPI:-0} in
                                ;;
                esac
 
-               if [[ "${GENTOO_DEPEND_ON_PERL_SUBSLOT}" ]]; then
-                       eerror "GENTOO_DEPEND_ON_PERL_SUBSLOT is banned in EAPI=6. If you don't want a slot operator"
+               if [[ "${GENTOO_DEPEND_ON_PERL_SUBSLOT:-yes}" != "yes" ]]; then
+                       eerror "GENTOO_DEPEND_ON_PERL_SUBSLOT=no is banned in EAPI=6. If you don't want a slot operator"
                        die    "set GENTOO_DEPEND_ON_PERL=noslotop instead."
                fi