Re: [PATCH] contrib: pick: bugfix when trying to show a non-message

diff --git a/ae/798c66bc28ffbc24fe2f02222b2d33363bb2a9 b/ae/798c66bc28ffbc24fe2f02222b2d33363bb2a9
new file mode 100644 (file)
index 0000000..a4a271e
--- /dev/null
+++ b/ae/798c66bc28ffbc24fe2f02222b2d33363bb2a9
@@ -0,0 +1,65 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 49D08431FB6\r
+       for <notmuch@notmuchmail.org>; Thu,  8 Nov 2012 18:57:47 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Bfw1OMqleA15 for <notmuch@notmuchmail.org>;\r
+       Thu,  8 Nov 2012 18:57:46 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id B4DF7431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  8 Nov 2012 18:57:46 -0800 (PST)\r
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.89.108] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TWems-0000ew-Rf; Thu, 08 Nov 2012 22:57:43 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TWemn-0007yK-AT; Thu, 08 Nov 2012 22:57:37 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] contrib: pick: bugfix when trying to show a non-message\r
+In-Reply-To: <1351797983-19707-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1351797983-19707-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.14+75~g984212d (http://notmuchmail.org) Emacs/24.1.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 08 Nov 2012 22:57:37 -0400\r
+Message-ID: <87ehk332la.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 09 Nov 2012 02:57:47 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> -  (concat "id:\"" (notmuch-pick-get-prop :id) "\""))\r
+> +  (let ((id (notmuch-pick-get-prop :id)))\r
+> +    (when id\r
+> +      (concat "id:\"" id "\""))))\r
+\r
+I don't know how other people feel, but I'd rather have an `if' in a\r
+context where I care about the return value.\r