--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0929E431E64\r
+ for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 00:15:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.7\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.7 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id PZA35Pk66ezW for <notmuch@notmuchmail.org>;\r
+ Mon, 30 Jan 2012 00:15:00 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+ [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 20622431FBC\r
+ for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 00:14:59 -0800 (PST)\r
+Received: by bke11 with SMTP id 11so1141870bke.26\r
+ for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 00:14:58 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+ h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+ :message-id:mime-version:content-type;\r
+ bh=HP7QMRYHrEreJanQvnTreMDiNPB1ter0cy3wvITzj6I=;\r
+ b=uK6AqctiAOwxVQOglcrpZgOwRElf1qx5z5U8q/1mwrcI7XBxXRWkz0PN7somuWyG37\r
+ IoegAUGxSj7xqkBKXreSipugMsAshgqyFJmeRJyPnEWD+Y4Y030UBV6gS8AtKnM66juZ\r
+ kIY6OMnkEB9ekI1STsxgl7JZoqfL/gPTPD55Q=\r
+Received: by 10.204.136.197 with SMTP id s5mr8180363bkt.9.1327911298677;\r
+ Mon, 30 Jan 2012 00:14:58 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id z15sm33042575bkd.7.2012.01.30.00.14.57\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Mon, 30 Jan 2012 00:14:57 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Pieter Praet <pieter@praet.org>\r
+Subject: Re: [PATCH v4] test: emacs: add test for `notmuch-search-operate-all'\r
+In-Reply-To: <1327909550-6788-1-git-send-email-pieter@praet.org>\r
+References: <1327599289-16865-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+ <1327909550-6788-1-git-send-email-pieter@praet.org>\r
+User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 30 Jan 2012 12:13:48 +0400\r
+Message-ID: <87y5spober.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 08:15:01 -0000\r
+\r
+Hi Pieter.\r
+\r
+On Mon, 30 Jan 2012 08:45:50 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> `notmuch-search-operate-all' (bound to "*") adds and removes tags\r
+> to/from all messages which match the query used to populate the\r
+> current search buffer.\r
+> \r
+> ---\r
+> \r
+> Rebased to current master.\r
+> \r
+> Previous versions (chronologically):\r
+> - id:"1309450108-2793-1-git-send-email-pieter@praet.org"\r
+> - id:"1309762318-4530-5-git-send-email-pieter@praet.org"\r
+> - id:"1310313335-4159-5-git-send-email-pieter@praet.org"\r
+> \r
+\r
+This looks like a useful patch series. We definitely need more tests\r
+for tagging operations in the Emacs UI. Do you plan to revive it?\r
+\r
+Note that not so long ago I posted a bunch of tagging-related patches\r
+[1] that would conflict with this patch at least because of\r
+`notmuch-search-operate-all' being renamed to `notmuch-search-tag-all'.\r
+\r
+> \r
+> test/emacs | 19 +++++++++++++++++++\r
+> 1 files changed, 19 insertions(+), 0 deletions(-)\r
+> \r
+> diff --git a/test/emacs b/test/emacs\r
+> index 8ca4c8a..e94ad94 100755\r
+> --- a/test/emacs\r
+> +++ b/test/emacs\r
+> @@ -124,6 +124,25 @@ test_emacs "(notmuch-show \"$os_x_darwin_thread\")\r
+> output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+> test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"\r
+> \r
+> +test_begin_subtest "Add/remove tags to/from all matching messages."\r
+> +test_emacs '(notmuch-search "tag:inbox AND tags")\r
+> + (notmuch-test-wait)\r
+> + (notmuch-search-operate-all "+matching" "-inbox")\r
+> + (notmuch-search "tag:matching AND NOT tag:inbox")\r
+> + (notmuch-test-wait)\r
+> + (test-output)'\r
+> +cat <<EOF >EXPECTED\r
+> + 2009-11-18 [3/3] Adrian Perez de Castro, Keith Packard, Carl Worth [notmuch] Introducing myself (matching signed unread)\r
+> + 2009-11-18 [1/3] Carl Worth, Israel Herraiz, Keith Packard [notmuch] New to the list (inbox matching unread)\r
+> + 2009-11-18 [2/2] Keith Packard, Carl Worth [notmuch] [PATCH] Make notmuch-show 'X' (and 'x') commands remove inbox (and unread) tags (matching unread)\r
+> + 2009-11-18 [1/2] Keith Packard, Alexander Botero-Lowry [notmuch] [PATCH] Create a default notmuch-show-hook that highlights URLs and uses word-wrap (inbox matching unread)\r
+> + 2009-11-18 [1/1] Jan Janak [notmuch] [PATCH] notmuch new: Support for conversion of spool subdirectories into tags (matching unread)\r
+> + 2009-11-18 [1/1] Stewart Smith [notmuch] [PATCH] Fix linking with gcc to use g++ to link in C++ libs. (matching unread)\r
+> + 2009-11-17 [1/2] Ingmar Vanhassel, Carl Worth [notmuch] [PATCH] Typsos (inbox matching unread)\r
+> +End of search results.\r
+> +EOF\r
+> +test_expect_equal_file OUTPUT EXPECTED\r
+\r
+I am worried that this test would break because of changes in other\r
+tests. E.g. if a new test adds a new message which matches "tag:inbox\r
+AND tags", this test would have to be updated. I think we should avoid\r
+this. I see the following options here:\r
+\r
+* Search for messages which are less likely to change, e.g. "from:carl".\r
+\r
+* Rework the test to avoid using any fixed expected results, e.g.:\r
+\r
+ - count all messages with tag:inbox\r
+\r
+ - remove inbox tag, add some other distinct tag for all messages with\r
+ tag:inbox\r
+\r
+ - count all messages with tag:inbox again, check that it is 0\r
+\r
+ - add the inbox tag back, remove the previously added tag, check the\r
+ message count\r
+\r
+I like the latter approach because it does not compare Emacs UI output\r
+and hence would not break when that output changes. What do you think?\r
+\r
+Also, we should leave notmuch db in the same state as it was before the\r
+test if possible.\r
+\r
+Regards,\r
+ Dmitry\r
+\r
+[1] id:"1327901644-15799-1-git-send-email-dmitry.kurochkin@gmail.com"\r
+\r
+> +\r
+> test_begin_subtest "Message with .. in Message-Id:"\r
+> add_message [id]=123..456@example '[subject]="Message with .. in Message-Id"'\r
+> test_emacs '(notmuch-search "id:\"123..456@example\"")\r
+> -- \r
+> 1.7.8.1\r
+> \r
projects / notmuch-archives.git / commitdiff