Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)

diff --git a/8c/7c11b383f44185bcafa7548698761ae5cf18f8 b/8c/7c11b383f44185bcafa7548698761ae5cf18f8
new file mode 100644 (file)
index 0000000..2473a13
--- /dev/null
+++ b/8c/7c11b383f44185bcafa7548698761ae5cf18f8
@@ -0,0 +1,112 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C4A9A431FAE\r
+       for <notmuch@notmuchmail.org>; Fri,  6 Apr 2012 09:20:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id xH1P7IqTWB6S for <notmuch@notmuchmail.org>;\r
+       Fri,  6 Apr 2012 09:20:07 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id D4BE4431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  6 Apr 2012 09:20:04 -0700 (PDT)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id 7C38D66E0107;\r
+       Fri,  6 Apr 2012 09:20:02 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (DHCP-123-229.caltech.edu [131.215.123.229])\r
+       (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 69CFC66E010E;\r
+       Fri,  6 Apr 2012 09:19:55 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 522A23BC; Fri,  6 Apr 2012 09:19:55 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)\r
+In-Reply-To: <87ty0w50r7.fsf@qmul.ac.uk>\r
+References: <1333716551-29153-1-git-send-email-markwalters1009@gmail.com>\r
+       <87bon47v0o.fsf@servo.finestructure.net>\r
+       <87ty0w50r7.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.12+93~gd54240d (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 06 Apr 2012 09:19:52 -0700\r
+Message-ID: <877gxs7ryv.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 06 Apr 2012 16:20:11 -0000\r
+\r
+--=-=-=\r
+\r
+On Fri, Apr 06 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> There are some exclude tests for count in test/count. Do you think it\r
+> needs to be a full test everything like in test/search-exclude?\r
+\r
+Ah yes.  Somehow I missed that.\r
+\r
+I might prefer to keep all exclude tests in one test script.  In which\r
+case it would be good to move the count exclude tests there, and maybe\r
+round it out by testing both exclude options.\r
+\r
+> There aren't any tests for show exclude, but there aren't very many\r
+> tests explicitly for show anyway. My preference would be to add\r
+> something like\r
+> id:"1332171061-27983-1-git-send-email-markwalters1009@gmail.com" and add\r
+> some tests to that.\r
+\r
+Oh wow I wonder why that hasn't been pushed yet.  That's a bunch of new\r
+good tests.  It's a long changeset, which is probably why there aren't\r
+any reviews, but it's all test additions so we should definitely\r
+fast-track it.  I'll try to look at it this weekend.\r
+\r
+> I could add some tests for show-excludes in the same format as the\r
+> search-exclude tests though if you think that is better.\r
+\r
+As I mentioned above, I personally think it would nice to test all the\r
+exclude functionality in one test script.  So I would vote for adding\r
+some show exclude tests there.  Definitely doesn't need to be as\r
+exhaustive as the search tests, but at least covering both cli options.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPfxepAAoJEO00zqvie6q8q9AP/jaBXI13C8YX/GQzxa7YPgdH\r
+yE0tmUVct6IkghiA4mxYDh8Kw/qYuA5MIdAoqphfJF9kQlfOyHHOMaaPTn3fj/Ij\r
+/SXCH11EyDhoTlJKkAJ303/uHCbtbK2JIqBKXFXpQiTbrrb5+6IJw0lWk2y4+4pO\r
+BRVo3zy0Zx2NYrX9hxGmF2G7Fhn6sJNTcbWJTtoP3Oh+TDsd+28R4b0ujJVIm3N4\r
+QjW3QTS3vIAOpyFt1lsvnosRRwPD39fN/Yf5gMR/VobF0v021F/uk+Z16VxgTaWu\r
+Higy4nivYCGn+7IXV8BmmzgYJOyxIIBO0D3cfFsgECnJjOUBFbYtauAm2kGotXrV\r
+8+PgL9Bt3yDR7zTNsVUP6Il8FRNn6n2YOuWXRSKcFfvK8wPP98FOvO/2AeBsHNVW\r
+9/a2Wtor03DRzxPoZhFDvTpqRsIayIauCDvKh19AUT1gdVJod+oJEa+/pzAGbmHP\r
+jxPiQPePeYdvDqym0RWXAMUFdKRXWbTFU0qKKvD3zcwuzNHJiOzo7uV2Sfvzz4xD\r
+Ke8TVuWJxskXyzI/rqMY+c189xH++5uhDqsZy7AY+3WyuMkbDvFkX4Bx48XBEm2O\r
+FKUJ7JunseCYRUEktUvJlawYn/PY95UICoOeCBA8kgFTZievWI7h9JPpowhq+O6z\r
+P6l+uhFFdgNz8/j6BCdB\r
+=pLRB\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r