[PATCH 4/5] Annotate internal_error with the attribute noreturn

diff --git a/e3/5ec7e9f106310e5fa1ba0006125411f3c38e09 b/e3/5ec7e9f106310e5fa1ba0006125411f3c38e09
new file mode 100644 (file)
index 0000000..1128e8c
--- /dev/null
+++ b/e3/5ec7e9f106310e5fa1ba0006125411f3c38e09
@@ -0,0 +1,116 @@
+Return-Path: <teythoon@jade-hamburg.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id ECF91431FBD\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Sep 2012 03:32:25 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.001\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.001 tagged_above=-999 required=5\r
+       tests=[UNPARSEABLE_RELAY=0.001] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id C502J7KjonSk for <notmuch@notmuchmail.org>;\r
+       Mon, 24 Sep 2012 03:32:24 -0700 (PDT)\r
+Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D4B84431FC3\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Sep 2012 03:32:19 -0700 (PDT)\r
+Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by mail.cryptobitch.de (Postfix) with ESMTPSA id 9D1B85AA9C2\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Sep 2012 12:32:18 +0200 (CEST)\r
+Received: by mail.jade-hamburg.de (Postfix, from userid 401)\r
+       id 10C03DF2A7; Mon, 24 Sep 2012 12:32:18 +0200 (CEST)\r
+Received: from thinkbox.jade-hamburg.de (unknown\r
+       [IPv6:fe80::216:d3ff:fe3e:5058%br0])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested) (Authenticated sender: teythoon)\r
+       by mail.jade-hamburg.de (Postfix) with ESMTPSA id 252BCDF2A2;\r
+       Mon, 24 Sep 2012 12:32:11 +0200 (CEST)\r
+Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.80)\r
+       (envelope-from <teythoon@thinkbox.jade-hamburg.de>)\r
+       id 1TG5xR-0002iD-T3; Mon, 24 Sep 2012 12:32:09 +0200\r
+From: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 4/5] Annotate internal_error with the attribute noreturn\r
+Date: Mon, 24 Sep 2012 12:31:56 +0200\r
+Message-Id:\r
+ <1348482717-10340-5-git-send-email-4winter@informatik.uni-hamburg.de>\r
+X-Mailer: git-send-email 1.7.10.4\r
+In-Reply-To:\r
+ <1348482717-10340-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+References: <20120922161256.GE26662@mit.edu>\r
+       <1348482717-10340-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 24 Sep 2012 10:32:26 -0000\r
+\r
+Annotating functions that do not return with the noreturn attribute\r
+(which is understood by both gcc and clang) prevents static analyzers\r
+from generating false positives (internal_error is used to terminate\r
+the process and is used extensively in error handling code paths).\r
+\r
+Remove the return statement that was placed there to appease the\r
+compiler. Functions annotated with noreturn are not supposed to return\r
+any values.\r
+\r
+Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+---\r
+ util/error_util.c |    4 +---\r
+ util/error_util.h |    4 ++--\r
+ 2 files changed, 3 insertions(+), 5 deletions(-)\r
+\r
+diff --git a/util/error_util.c b/util/error_util.c\r
+index 630d228..d6e60fc 100644\r
+--- a/util/error_util.c\r
++++ b/util/error_util.c\r
+@@ -24,7 +24,7 @@\r
+ \r
+ #include "error_util.h"\r
+ \r
+-int\r
++void\r
+ _internal_error (const char *format, ...)\r
+ {\r
+     va_list va_args;\r
+@@ -35,7 +35,5 @@ _internal_error (const char *format, ...)\r
+     vfprintf (stderr, format, va_args);\r
+ \r
+     exit (1);\r
+-\r
+-    return 1;\r
+ }\r
+ \r
+diff --git a/util/error_util.h b/util/error_util.h\r
+index 27e119f..d4d4584 100644\r
+--- a/util/error_util.h\r
++++ b/util/error_util.h\r
+@@ -53,8 +53,8 @@\r
+  *\r
+  * Note that PRINTF_ATTRIBUTE comes from talloc.h\r
+  */\r
+-int\r
+-_internal_error (const char *format, ...) PRINTF_ATTRIBUTE (1, 2);\r
++void\r
++_internal_error (const char *format, ...) PRINTF_ATTRIBUTE (1, 2) NORETURN_ATTRIBUTE;\r
+ \r
+ /* There's no point in continuing when we've detected that we've done\r
+  * something wrong internally (as opposed to the user passing in a\r
+-- \r
+1.7.10.4\r
+\r