--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 842CB431FAF\r
+ for <notmuch@notmuchmail.org>; Sun, 25 Nov 2012 19:29:12 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id fKGrvirsBoZr for <notmuch@notmuchmail.org>;\r
+ Sun, 25 Nov 2012 19:29:11 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU\r
+ [18.7.68.36])\r
+ by olra.theworths.org (Postfix) with ESMTP id C952C431FAE\r
+ for <notmuch@notmuchmail.org>; Sun, 25 Nov 2012 19:29:11 -0800 (PST)\r
+X-AuditID: 12074424-b7fbe6d000003b02-b3-50b2e207325b\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+ by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 77.C9.15106.702E2B05; Sun, 25 Nov 2012 22:29:11 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id qAQ3T99E011765; \r
+ Sun, 25 Nov 2012 22:29:10 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qAQ3T7B2016560\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Sun, 25 Nov 2012 22:29:08 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1TcpNb-0005wO-0a; Sun, 25 Nov 2012 22:29:07 -0500\r
+Date: Sun, 25 Nov 2012 22:29:06 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [Patch v4 2/2] test: initial performance testing infrastructure\r
+Message-ID: <20121126032906.GP4562@mit.edu>\r
+References: <1353855745-11697-1-git-send-email-david@tethera.net>\r
+ <1353855745-11697-3-git-send-email-david@tethera.net>\r
+ <20121125214023.GO4562@mit.edu> <87obilut2h.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87obilut2h.fsf@zancas.localnet>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IRYrdT0WV/tCnAYNU7YYsbrd2MFtdvzmR2\r
+ YPJ4tuoWs8eWQ++ZA5iiuGxSUnMyy1KL9O0SuDLa/zYxFjzgr+hbu5+pgXEVTxcjJ4eEgInE\r
+ 9Uvz2SFsMYkL99azgdhCAvsYJba2hXUxcgHZGxgltk89xALhXGSSmNlxhwmiagmjxKdjIV2M\r
+ HBwsAqoSux/pg4TZBDQktu1fzghiiwCFr26bDDaUWUBa4tvvZrBWYQEfiXO7ZoHZvALaErcm\r
+ fmOEmA+0eMOl42wQCUGJkzOfsEA0a0nc+PeSCWQXyKDl/zhAwpwCuhLbTi0FKxEVUJGYcnIb\r
+ 2wRGoVlIumch6Z6F0L2AkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqRrrlebmaJXmpK6SZGcFC7\r
+ qOxgbD6kdIhRgINRiYdX4timACHWxLLiytxDjJIcTEqivJfuA4X4kvJTKjMSizPii0pzUosP\r
+ MUpwMCuJ8E5kAsrxpiRWVqUW5cOkpDlYlMR5r6fc9BcSSE8sSc1OTS1ILYLJynBwKEnwsj4E\r
+ ahQsSk1PrUjLzClBSDNxcIIM5wEaLglSw1tckJhbnJkOkT/FqCglzqsEkhAASWSU5sH1wpLO\r
+ K0ZxoFeEeTVBqniACQuu+xXQYCagwcnXN4IMLklESEk1MEbkq9vcebBv0pycr0+yzkkmWPe5\r
+ b/3yoWdyLK9730uFZr//LaqTLu2++PX9pFOuOxl2dTw/pXeHt6bqYPB/jc1n3i+UmbjZLTrS\r
+ v3rNrPbT+cXTr00LMNy23vvCUfdV4U57kxwWvq902vVDwPgS09cn8+67bfv9nlOi6lfrtl85\r
+ 6tJhB6539C9TYinOSDTUYi4qTgQAaPnSUxUDAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 26 Nov 2012 03:29:12 -0000\r
+\r
+Quoth David Bremner on Nov 25 at 8:05 pm:\r
+> Austin Clements <amdragon@MIT.EDU> writes:\r
+> >> +add_email_corpus takes arguments "--small" and "--medium" for when you\r
+> >> +want smaller corpuses to check.\r
+> >\r
+> > "corpora"?\r
+> \r
+> reworded to say \r
+> \r
+> ,----\r
+> | add_email_corpus takes arguments "--small" and "--medium" for when you\r
+> | want smaller subsets of the corpus to check.\r
+> `----\r
+\r
+That's clearer.\r
+\r
+> >\r
+> > I'm a bit confused by this. What happens if you don't specify --small\r
+> > or --medium? Is the "large"/default corpus just the combined small\r
+> > and medium corpora? Would be worth a comment, at least.\r
+> \r
+> Hopefully the README makes this clear(er) now?\r
+\r
+The README definitely helps. Might still be worth a comment in the\r
+code since it took me some thinking to realize it would do something\r
+reasonable when given no argument. Perhaps above the initial\r
+assignment of arg,\r
+\r
+# With no argument, use the entire (combined) corpus\r
+\r
+to acknowledge that this is a legitimate and intentional code path?\r
+\r
+> > This probably doesn't matter now, but I wonder if we want to unpack on\r
+> > first use to somewhere not test-specific and then cp -rl the corpus\r
+> > into the test directory. I haven't tried unpacking the corpus yet,\r
+> > but if you're running tests repeatedly to compare results, or running\r
+> > more than one performance test, it seems like a full decompress and\r
+> > unpack could get onerous.\r
+> \r
+> Hmm. On my machine it is 10s for the copy versus 45s for a full\r
+> unpack. For some reason I tested with "cp -a" which is incredibly slow, \r
+> so I thought there was no loss. For comparison the basic test takes\r
+> about 10 minutes on the same machine.\r
+> \r
+> In any case this can wait until we have a second test file and a second\r
+> call to add_mail_corpus, adding caching now would not help.\r
+\r
+It would help (a little) if you run basic multiple times. I think\r
+it's completely reasonable to leave it as is for now and see if\r
+caching would help down the road.\r
projects / notmuch-archives.git / commitdiff