Re: [PATCH] config: add quoting to fix IFS bug

diff --git a/d6/ef25f44a992bcd3d7db39b0f44ad10e6f0e5ee b/d6/ef25f44a992bcd3d7db39b0f44ad10e6f0e5ee
new file mode 100644 (file)
index 0000000..67c32f0
--- /dev/null
+++ b/d6/ef25f44a992bcd3d7db39b0f44ad10e6f0e5ee
@@ -0,0 +1,88 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7CA9D431FB6\r
+       for <notmuch@notmuchmail.org>; Sun,  3 Jun 2012 08:07:02 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id E6PkJ0LIRDw0 for <notmuch@notmuchmail.org>;\r
+       Sun,  3 Jun 2012 08:07:01 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id BE13C431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  3 Jun 2012 08:07:01 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 51F5510014D; Sun,  3 Jun 2012 18:07:11 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH] config: add quoting to fix IFS bug\r
+In-Reply-To: <1338660961-13760-1-git-send-email-jrollins@finestructure.net>\r
+References: <1338660961-13760-1-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Notmuch/0.13+29~g3c353b7 (http://notmuchmail.org) Emacs/23.1.1\r
+       (x86_64-redhat-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 03 Jun 2012 18:07:11 +0300\r
+Message-ID: <m2bol0juxs.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 03 Jun 2012 15:07:02 -0000\r
+\r
+On Sat, Jun 02 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+\r
+> Without proper quoting the DEFAULT_IFS was getting set incorrectly,\r
+> which was causing problems with the storage of some variables later in\r
+> the script.  Quoting fixes the problem.\r
+\r
+LGTM\r
+\r
+Tomi\r
+\r
+\r
+> ---\r
+> Thanks to Tomi for the inspiration for this fix.  I don't know how I\r
+> missed such a simple solution initially.\r
+>\r
+>  configure |    2 +-\r
+>  1 file changed, 1 insertion(+), 1 deletion(-)\r
+>\r
+> diff --git a/configure b/configure\r
+> index 5602be2..3fad424 100755\r
+> --- a/configure\r
+> +++ b/configure\r
+> @@ -1,7 +1,7 @@\r
+>  #! /bin/sh\r
+>  \r
+>  # Store original IFS value so it can be changed (and restored) in many places.\r
+> -readonly DEFAULT_IFS=$IFS\r
+> +readonly DEFAULT_IFS="$IFS"\r
+>  \r
+>  srcdir=$(dirname "$0")\r
+>  \r
+> -- \r
+> 1.7.10\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r