bitcoincore.eclass: Always use HTTPS for accessing GitHub
authorDavid Hicks <david@hicks.id.au>
Sat, 29 Jul 2017 10:48:45 +0000 (20:48 +1000)
committerMichał Górny <mgorny@gentoo.org>
Sun, 30 Jul 2017 09:15:49 +0000 (11:15 +0200)
To prevent MITM attacks, always use HTTPS with GitHub domains. GitHub
supports "Smart HTTPS" git which means that shallow clones are possible
over HTTPS. Don't use a git:// fallback because this would allow an
attacker to always force fallback to an unsafe protocol.

eclass/bitcoincore.eclass

index 6144fb8ee68c975f15aa0c447a1f1fef4a1638c9..22bc5db1df7576ba4877c0c8fb2d806cc223ef82 100644 (file)
@@ -131,7 +131,7 @@ HOMEPAGE="http://bitcoincore.org/"
 
 if [ -z "$BITCOINCORE_COMMITHASH" ]; then
        EGIT_PROJECT='bitcoin'
-       EGIT_REPO_URI="git://github.com/bitcoin/bitcoin.git https://github.com/bitcoin/bitcoin.git"
+       EGIT_REPO_URI="https://github.com/bitcoin/bitcoin.git"
 else
        SRC_URI="https://github.com/${MyPN}/${MyPN}/archive/${BITCOINCORE_COMMITHASH}.tar.gz -> ${MyPN}-v${PV}${BITCOINCORE_SRC_SUFFIX}.tgz"
        if [ -z "${BITCOINCORE_NO_SYSLIBS}" ]; then