--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 99013429E4E\r
+ for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 18:27:47 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 40tB1drEOhG2 for <notmuch@notmuchmail.org>;\r
+ Sun, 29 Jan 2012 18:27:45 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+ [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id A5EA0429E34\r
+ for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 18:27:43 -0800 (PST)\r
+Received: by mail-bk0-f53.google.com with SMTP id 11so960260bke.26\r
+ for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 18:27:43 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+ h=from:to:subject:date:message-id:x-mailer:in-reply-to:references;\r
+ bh=BRoFNgFZMGszZ0lxWKjSYg5xKR9s/9rVloL7JNfGA0g=;\r
+ b=FxSWprgPtvSM0lKIWQhZUNBHIdo8CbuNYEWapWNmso2hEKvt6rysOyWWMDpeFBEuO6\r
+ U005xeyvVR/XRh3JGBhYNkj8WiD26JFnHRXcXE/S2JWfS0B5TIRtyNZx4P8l/6MEiL8K\r
+ CR5eXyrFcHIhvO/Sv0OcqneQa2unO28WoEflc=\r
+Received: by 10.204.148.73 with SMTP id o9mr7823821bkv.46.1327890463377;\r
+ Sun, 29 Jan 2012 18:27:43 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id ek9sm34251370bkb.10.2012.01.29.18.27.42\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Sun, 29 Jan 2012 18:27:42 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v2 04/13] emacs: make "+" and "-" tagging operations in\r
+ notmuch-show more robust\r
+Date: Mon, 30 Jan 2012 06:26:13 +0400\r
+Message-Id: <1327890382-548-5-git-send-email-dmitry.kurochkin@gmail.com>\r
+X-Mailer: git-send-email 1.7.8.3\r
+In-Reply-To: <1327890382-548-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+ <1327890382-548-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 02:27:48 -0000\r
+\r
+Before the change, "+" and "-" tagging operations in notmuch-show view\r
+accepted only a single tag. The patch makes them use the recently\r
+added `notmuch-read-tag-changes' function, which allows to enter\r
+multiple tags with "+" and "-" prefixes. So after the change, "+" and\r
+"-" bindings in notmuch-show view allow to both add and remove\r
+multiple tags. The only difference between "+" and "-" is the\r
+minibuffer initial input ("+" and "-" respectively).\r
+---\r
+ emacs/notmuch-show.el | 64 +++++++++++++++++-------------------------------\r
+ 1 files changed, 23 insertions(+), 41 deletions(-)\r
+\r
+diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+index 84ac624..11dab2d 100644\r
+--- a/emacs/notmuch-show.el\r
++++ b/emacs/notmuch-show.el\r
+@@ -38,8 +38,9 @@\r
+ \r
+ (declare-function notmuch-call-notmuch-process "notmuch" (&rest args))\r
+ (declare-function notmuch-fontify-headers "notmuch" nil)\r
+-(declare-function notmuch-select-tag-with-completion "notmuch" (prompt &rest search-terms))\r
++(declare-function notmuch-read-tag-changes "notmuch" (&optional initial-input &rest search-terms))\r
+ (declare-function notmuch-search-show-thread "notmuch" nil)\r
++(declare-function notmuch-update-tags "notmuch" (current-tags tag-changes))\r
+ \r
+ (defcustom notmuch-message-headers '("Subject" "To" "Cc" "Date")\r
+ "Headers that should be shown in a message, in this order.\r
+@@ -1267,7 +1268,7 @@ Some useful entries are:\r
+ \r
+ (defun notmuch-show-mark-read ()\r
+ "Mark the current message as read."\r
+- (notmuch-show-remove-tag "unread"))\r
++ (notmuch-show-tag-message "-unread"))\r
+ \r
+ ;; Functions for getting attributes of several messages in the current\r
+ ;; thread.\r
+@@ -1470,51 +1471,32 @@ than only the current message."\r
+ (message (format "Command '%s' exited abnormally with code %d"\r
+ shell-command exit-code))))))))\r
+ \r
+-(defun notmuch-show-add-tags-worker (current-tags add-tags)\r
+- "Add to `current-tags' with any tags from `add-tags' not\r
+-currently present and return the result."\r
+- (let ((result-tags (copy-sequence current-tags)))\r
+- (mapc (lambda (add-tag)\r
+- (unless (member add-tag current-tags)\r
+- (setq result-tags (push add-tag result-tags))))\r
+- add-tags)\r
+- (sort result-tags 'string<)))\r
+-\r
+-(defun notmuch-show-del-tags-worker (current-tags del-tags)\r
+- "Remove any tags in `del-tags' from `current-tags' and return\r
+-the result."\r
+- (let ((result-tags (copy-sequence current-tags)))\r
+- (mapc (lambda (del-tag)\r
+- (setq result-tags (delete del-tag result-tags)))\r
+- del-tags)\r
+- result-tags))\r
+-\r
+-(defun notmuch-show-add-tag (&rest toadd)\r
+- "Add a tag to the current message."\r
+- (interactive\r
+- (list (notmuch-select-tag-with-completion "Tag to add: ")))\r
++(defun notmuch-show-tag-message (&rest tag-changes)\r
++ "Change tags for the current message.\r
+ \r
++TAG-CHANGES is a list of tag operations for `notmuch-tag'."\r
+ (let* ((current-tags (notmuch-show-get-tags))\r
+- (new-tags (notmuch-show-add-tags-worker current-tags toadd)))\r
+-\r
++ (new-tags (notmuch-update-tags current-tags tag-changes)))\r
+ (unless (equal current-tags new-tags)\r
+- (apply 'notmuch-tag (notmuch-show-get-message-id)\r
+- (mapcar (lambda (s) (concat "+" s)) toadd))\r
++ (apply 'notmuch-tag (notmuch-show-get-message-id) tag-changes)\r
+ (notmuch-show-set-tags new-tags))))\r
+ \r
+-(defun notmuch-show-remove-tag (&rest toremove)\r
+- "Remove a tag from the current message."\r
+- (interactive\r
+- (list (notmuch-select-tag-with-completion\r
+- "Tag to remove: " (notmuch-show-get-message-id))))\r
++(defun notmuch-show-tag (&optional initial-input)\r
++ "Change tags for the current message, read input from the minibuffer."\r
++ (interactive)\r
++ (let ((tag-changes (notmuch-read-tag-changes\r
++ initial-input (notmuch-show-get-message-id))))\r
++ (apply 'notmuch-show-tag-message tag-changes)))\r
+ \r
+- (let* ((current-tags (notmuch-show-get-tags))\r
+- (new-tags (notmuch-show-del-tags-worker current-tags toremove)))\r
++(defun notmuch-show-add-tag ()\r
++ "Same as `notmuch-show-tag' but sets initial input to '+'."\r
++ (interactive)\r
++ (notmuch-show-tag "+"))\r
+ \r
+- (unless (equal current-tags new-tags)\r
+- (apply 'notmuch-tag (notmuch-show-get-message-id)\r
+- (mapcar (lambda (s) (concat "-" s)) toremove))\r
+- (notmuch-show-set-tags new-tags))))\r
++(defun notmuch-show-remove-tag ()\r
++ "Same as `notmuch-show-tag' but sets initial input to '-'."\r
++ (interactive)\r
++ (notmuch-show-tag "-"))\r
+ \r
+ (defun notmuch-show-toggle-headers ()\r
+ "Toggle the visibility of the current message headers."\r
+@@ -1559,7 +1541,7 @@ argument, hide all of the messages."\r
+ (defun notmuch-show-archive-thread-internal (show-next)\r
+ ;; Remove the tag from the current set of messages.\r
+ (goto-char (point-min))\r
+- (loop do (notmuch-show-remove-tag "inbox")\r
++ (loop do (notmuch-show-tag-message "-inbox")\r
+ until (not (notmuch-show-goto-message-next)))\r
+ ;; Move to the next item in the search results, if any.\r
+ (let ((parent-buffer notmuch-show-parent-buffer))\r
+-- \r
+1.7.8.3\r
+\r
projects / notmuch-archives.git / commitdiff