--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0E9E0431FAE\r
+ for <notmuch@notmuchmail.org>; Sun, 25 Nov 2012 13:21:05 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id hu43GlfC+j7Y for <notmuch@notmuchmail.org>;\r
+ Sun, 25 Nov 2012 13:21:04 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
+ [18.9.25.13])\r
+ by olra.theworths.org (Postfix) with ESMTP id 35323431FAF\r
+ for <notmuch@notmuchmail.org>; Sun, 25 Nov 2012 13:21:04 -0800 (PST)\r
+X-AuditID: 1209190d-b7f906d0000008de-63-50b28bbe7902\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+ by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 6B.68.02270.EBB82B05; Sun, 25 Nov 2012 16:21:03 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id qAPLL2KF012406; \r
+ Sun, 25 Nov 2012 16:21:02 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qAPLL05v001016\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Sun, 25 Nov 2012 16:21:01 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1TcjdL-0004HO-Sj; Sun, 25 Nov 2012 16:20:59 -0500\r
+Date: Sun, 25 Nov 2012 16:20:59 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 0/6] API for iterating over all messages in a thread\r
+Message-ID: <20121125212059.GN4562@mit.edu>\r
+References: <1353819427-13182-1-git-send-email-amdragon@mit.edu>\r
+ <87ehjhkb3a.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87ehjhkb3a.fsf@qmul.ac.uk>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hTV1t3fvSnA4PM+RovVc3ksrt+cyezA\r
+ 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZWxf84G54KFYxfstdxgbGL8KdjFyckgImEj8\r
+ fDaDFcIWk7hwbz1bFyMXh5DAPkaJN8962CGcDYwS/xesZIRwLjJJfJn0D8pZwiix9MQHFpB+\r
+ FgFVicc7HjOB2GwCGhLb9i9nBLFFBHQkbh9awA5iMwtIS3z73QxWIyzgIfHg908wm1dAW2Jp\r
+ 92+wGiGBOIk1X9tZIOKCEidnPmGB6NWSuPHvJVA9B9ic5f84QMKcQKvabkwFWyUqoCIx5eQ2\r
+ tgmMQrOQdM9C0j0LoXsBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXSO93MwSvdSU0k2M4LCW\r
+ 5N3B+O6g0iFGAQ5GJR7eG4kbA4RYE8uKK3MPMUpyMCmJ8ja3bgoQ4kvKT6nMSCzOiC8qzUkt\r
+ PsQowcGsJMI7kQkox5uSWFmVWpQPk5LmYFES572SctNfSCA9sSQ1OzW1ILUIJivDwaEkwWvf\r
+ BdQoWJSanlqRlplTgpBm4uAEGc4DNHxHJ8jw4oLE3OLMdIj8KUZFKXFeNZBmAZBERmkeXC8s\r
+ 7bxiFAd6RZiXEaSKB5iy4LpfAQ1mAhqcfH0jyOCSRISUVANj8H5rc/0I+ULHtkWbtOwO2C5i\r
+ Zt+hvsLoEotC4FXrz38+TFFuq3m+9uc+1Zwn/6MlNscFuhov3/zx8vaCw0q7f0dMiD06YcWa\r
+ 7NM2d5+J/Y9e7O3wdWqbyVktwzM12e2z2zIk9mp9cjrNaX6NMWmetpln2J5zByuYnurbe5oa\r
+ 3jbojHOSN7ZUYinOSDTUYi4qTgQA4EabchYDAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 25 Nov 2012 21:21:05 -0000\r
+\r
+Quoth Mark Walters on Nov 25 at 2:31 pm:\r
+> \r
+> Hi\r
+> \r
+> This series looks good to me (I have not reviewed the two bindings\r
+> patches). Patch 2 looks like it makes things much easier to follow than\r
+> the current code (if I understood the current pointer stuff it\r
+> constructs the top-level list by doing pointer stuff to remove all\r
+> messages which are replies from the complete message list). Indeed, the\r
+> diff is more complicated than the new code!\r
+> \r
+> On Sun, 25 Nov 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > This series adds a library API for iterating over all messages in a\r
+> > thread in sorted order. This is easy for the library to provide and\r
+> > difficult to obtain from the current API. Plus, if you don't count\r
+> > the code added to the bindings, this series is actually a net\r
+> > decrease of 4 lines of code because of simplifications it enables.\r
+> >\r
+> > Do we want the API to do more? Currently it's very minimal, but I can\r
+> > imagine two ways it could be generalized. It could take an argument\r
+> > to indicate which message list to return, which could be all messages,\r
+> > matched messages, top-level messages, or maybe even unmatched messages\r
+> > (possibly all in terms of message flags). It could also take an\r
+> > argument indicating the desired sort order. Currently, the caller can\r
+> > use existing message flag APIs to distinguish matched and unmatched\r
+> > messages and there's a separate function for the top-level messages.\r
+> > However, if the API could do all of these things, it would subsume\r
+> > various other API functions, such as notmuch_thread_get_*_date.\r
+> \r
+> I don't know if this is the right API. For the matched message etc I\r
+> think using the existing message flag APIs is simple enough. I am not\r
+> sure about sort orders though: that looks like it would be much easier\r
+> for the caller to have the correct sort by I am not sure what users\r
+> would need it.\r
+\r
+For sort order, I would be inclined to simply construct the reverse\r
+list the first time a caller asks for it. Theoretically the caller\r
+could do this just as easily as the library, except that we don't\r
+expose the list routines.\r
+\r
+If I do add sort order, I would also want to add some control over\r
+which list is returned, since it would be asymmetric to be able to\r
+request all messages in either order, but top-level messages only in\r
+oldest-first. I think this would be pretty simple, and would give us\r
+a reasonably general-purpose and extensible API. (It would also solve\r
+the naming conundrum I mentioned below in my original email.)\r
+\r
+> Best wishes\r
+> \r
+> Mark\r
+> \r
+> \r
+> \r
+> \r
+> >\r
+> > Also, is this the right name for the new API? In particular, if we do\r
+> > later want to add a function that returns, say, the list of matched\r
+> > messages, we'll have a convention collision with\r
+> > notmuch_thread_get_matched_messages, which returns only a count.\r
projects / notmuch-archives.git / commitdiff