Re: [PATCH v2] emacs: Fix display of highlighted line in notmuch-search

diff --git a/62/05b1ff4e3d2211793798ba9924864e23c4d70d b/62/05b1ff4e3d2211793798ba9924864e23c4d70d
new file mode 100644 (file)
index 0000000..c7651a0
--- /dev/null
+++ b/62/05b1ff4e3d2211793798ba9924864e23c4d70d
@@ -0,0 +1,91 @@
+Return-Path: <sojka@os.inf.tu-dresden.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B5940429E42\r
+       for <notmuch@notmuchmail.org>; Wed, 15 Feb 2012 15:18:42 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id qGbAYiqjZHXX for <notmuch@notmuchmail.org>;\r
+       Wed, 15 Feb 2012 15:18:38 -0800 (PST)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id C441C431E62\r
+       for <notmuch@notmuchmail.org>; Wed, 15 Feb 2012 15:18:38 -0800 (PST)\r
+Received: from localhost (unknown [192.168.200.4])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id C611E19F3600;\r
+       Thu, 16 Feb 2012 00:18:37 +0100 (CET)\r
+X-Virus-Scanned: IMAP AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+       by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,\r
+       port 10044)\r
+       with ESMTP id 9btytyhE69PC; Thu, 16 Feb 2012 00:18:32 +0100 (CET)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id 842AE19F35E3;\r
+       Thu, 16 Feb 2012 00:18:32 +0100 (CET)\r
+Received: from steelpick.2x.cz (cable-86-56-3-85.cust.telecolumbus.net\r
+       [86.56.3.85]) (Authenticated sender: sojkam1)\r
+       by imap.feld.cvut.cz (Postfix) with ESMTPSA id 6F856660968;\r
+       Thu, 16 Feb 2012 00:18:32 +0100 (CET)\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.77)\r
+       (envelope-from <sojka@os.inf.tu-dresden.de>)\r
+       id 1Rxo7L-0004z5-CH; Thu, 16 Feb 2012 00:18:31 +0100\r
+From: Michal Sojka <sojka@os.inf.tu-dresden.de>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: Fix display of highlighted line in\r
+       notmuch-search\r
+In-Reply-To: <87wr7ngand.fsf@gmail.com>\r
+References: <87mx8lpd5o.fsf@nikula.org>\r
+       <1329239387-6300-1-git-send-email-sojka@os.inf.tu-dresden.de>\r
+       <87wr7ngand.fsf@gmail.com>\r
+User-Agent: Notmuch/0.11.1+196~g4e14806 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 16 Feb 2012 00:18:31 +0100\r
+Message-ID: <87ehtvheig.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Mailman-Approved-At: Wed, 22 Feb 2012 08:28:25 -0800\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 15 Feb 2012 23:18:42 -0000\r
+\r
+On Wed, 15 Feb 2012, Dmitry Kurochkin wrote:\r
+> Hi Michal.\r
+> \r
+> On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka <sojka@os.inf.tu-dresden.de> wrote:\r
+> > When notmuch-search-line-faces is used to set background color in search\r
+> > results, the highlight of the current line is not always displayed\r
+> > correctly. This patch fixes that by increasing the priority property of\r
+> > the highlight overlay.\r
+> > ---\r
+> \r
+> How about changing `notmuch-search-color-line' to use text properties\r
+> instead of overlays?  Then hl-line overlay would take priority over it\r
+> without these changes.\r
+> \r
+> See [1] by David Edmondson on why text properties are better in\r
+> general.  I plan to use text properties here to simplify updating the\r
+> face when tags are changed.\r
+\r
+Hmm, I always wondered why notmuch uses overlays even if Elisp manual\r
+says they don't scale. I remember that I wanted to replace that long\r
+time ago, but there was some problem, which I forgot. Maybe it was the\r
+invisibility David mentions. I guess there is some invisible text in\r
+search output, isn't it?\r
+\r
+-Michal\r