Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t

diff --git a/ec/464ba56dbd7ad5d515d6ccb28c31576250b205 b/ec/464ba56dbd7ad5d515d6ccb28c31576250b205
new file mode 100644 (file)
index 0000000..f515a6d
--- /dev/null
+++ b/ec/464ba56dbd7ad5d515d6ccb28c31576250b205
@@ -0,0 +1,83 @@
+Return-Path: <adrien@bustany.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 29709431FCB\r
+       for <notmuch@notmuchmail.org>; Thu, 25 Oct 2012 11:39:44 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id xN+ffDjV+nIV for <notmuch@notmuchmail.org>;\r
+       Thu, 25 Oct 2012 11:39:43 -0700 (PDT)\r
+Received: from mail.bustany.org (bustany.org [176.31.244.208])\r
+       by olra.theworths.org (Postfix) with ESMTP id 22537431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 25 Oct 2012 11:39:43 -0700 (PDT)\r
+Received: from [192.168.1.147] (91-158-5-86.elisa-laajakaista.fi\r
+ [91.158.5.86])        by mail.bustany.org (Postfix) with ESMTPSA id BACFC140230;\r
+       Thu, 25 Oct 2012 20:43:35 +0200 (CEST)\r
+Message-ID: <50898769.2040202@bustany.org>\r
+Date: Thu, 25 Oct 2012 21:39:37 +0300\r
+From: Adrien Bustany <adrien@bustany.org>\r
+User-Agent: Mozilla/5.0 (X11; Linux x86_64;\r
+       rv:16.0) Gecko/20121009 Thunderbird/16.0\r
+MIME-Version: 1.0\r
+To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+Subject: Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t\r
+References: <1342723401-26103-1-git-send-email-adrien@bustany.org>\r
+       <1350510742-13447-1-git-send-email-adrien@bustany.org>\r
+       <87vce7yllt.fsf@nikula.org> <87y5j15ekv.fsf@betacantrips.com>\r
+In-Reply-To: <87y5j15ekv.fsf@betacantrips.com>\r
+Content-Type: text/plain; charset=ISO-8859-1; format=flowed\r
+Content-Transfer-Encoding: 8bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 25 Oct 2012 18:39:44 -0000\r
+\r
+Le 20/10/2012 18:49, Ethan Glasser-Camp a écrit :\r
+> Jani Nikula <jani@nikula.org> writes:\r
+>\r
+>> On Wed, 17 Oct 2012, Adrien Bustany <adrien@bustany.org> wrote:\r
+>>> The code of the patches in unchanged, but the formatting issues are now\r
+>>> hopefully fixed.\r
+>>\r
+>> Hi Adrien, please check at what version flush and reopen have been\r
+>> introduced to xapian. If they are new-ish (I don't know, didn't have the\r
+>> time to check), please add appropriate #ifdefs. [1] lays the groundwork\r
+>> for this. We'll also need to decide what is the minimum xapian version\r
+>> required in general, i.e. features earlier than that don't need\r
+>> conditional compilation.\r
+>\r
+> Hi! The new versions of these patches are still pretty trivial and they\r
+> still look OK to me, but based on Jani's prompting I decided to look up\r
+> the methods. Seems that flush() is a very old (pre-1.1.0, 2009-04) name\r
+> for commit(), which is the preferred name these days. You should\r
+> probably therefore rename the function notmuch_database_commit, and have\r
+> it call the WritableDatabase::commit() method.\r
+>\r
+> reopen() is a very very old method, seems like it has been around since\r
+> 2004.\r
+>\r
+> So I think Adrien is safe from having to do version checks, but we\r
+> should probably use commit() instead of flush().\r
+>\r
+> Ethan\r
+>\r
+\r
+Thanks for checking that! Sorry for the late answer, I had a hard time \r
+keeping on top of things lately...\r