Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

diff --git a/13/f292c5e111cd29cc0d3566f55e7e97fd34104a b/13/f292c5e111cd29cc0d3566f55e7e97fd34104a
new file mode 100644 (file)
index 0000000..4a43240
--- /dev/null
+++ b/13/f292c5e111cd29cc0d3566f55e7e97fd34104a
@@ -0,0 +1,113 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 70170431FB6\r
+       for <notmuch@notmuchmail.org>; Thu,  8 Nov 2012 00:55:38 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id YFKg8TAXYXcK for <notmuch@notmuchmail.org>;\r
+       Thu,  8 Nov 2012 00:55:37 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id BC8DB431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  8 Nov 2012 00:55:37 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id A6991100094;\r
+       Thu,  8 Nov 2012 10:55:36 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Blake Jones <blakej@foo.net>\r
+Subject: Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output\r
+       (Solaris support)\r
+In-Reply-To: <24582.1352356152@foo.net>\r
+References: <24582.1352356152@foo.net>\r
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 08 Nov 2012 10:55:36 +0200\r
+Message-ID: <m2bof8fp87.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 08 Nov 2012 08:55:38 -0000\r
+\r
+On Thu, Nov 08 2012, Blake Jones <blakej@foo.net> wrote:\r
+\r
+>>> @@ -11,10 +12,44 @@ fi\r
+>>>  HEADER=$1\r
+>>>  shift\r
+>>>  \r
+>>> +if [ `uname -s` == SunOS ] ; then\r
+>>> +    #\r
+>>> +    # Using Solaris "nm", a defined symbol looks like this:\r
+>>> +    #\r
+>> \r
+>> The POSIX / Bourne -comformant equality comparison is '='. \r
+>\r
+> Sigh, of course it is.  Fixed.\r
+>\r
+>> e.g.\r
+>> \r
+>> $ ./heirloom-sh/sh -c ' [ a == b ] || echo x'\r
+>> ./heirloom-sh/sh: test: unknown operator ==\r
+>> zsh: exit 1     ./heirloom-sh/sh -c ' [ a == b ] || echo x'\r
+>> \r
+>> Interesting that Solaris /bin/sh did not fail there...\r
+>\r
+> I was running on Solaris 11.1, which uses ksh93 as its /bin/sh.  You're\r
+> absolutely right that Solaris 10 would fall over, though.\r
+>\r
+> Similarly, the following line:\r
+>\r
+>     demangled=$(demangle $sym)\r
+>\r
+> doesn't work on traditional sh.  I've replaced $() with ``.\r
+>\r
+>> Hmm, gen-version-script doesn't have shebang... it is run like:\r
+>> \r
+>> sh $(srcdir)/$(lib)/gen-version-script.sh $< $(libnotmuch_modules) > $@\r
+>> \r
+>> in lib/Makefile.local -- taking sh fron PATH.\r
+>\r
+> I updated the first line from the #! invocation to a comment saying\r
+>\r
+>     # This script is invoked via "sh .../gen-version-script.sh".\r
+\r
+looks good\r
+\r
+> Would a respun version of these patches help toward testing?\r
+\r
+$ grep vim test/*\r
+zsh: exit 1     grep vim test/*\r
+\r
+i.e. no vim tests...\r
+\r
+Also, as *I* will execute my tests in Linux these won't make things\r
+fail -- and probably no-one else eager to test won't have problems\r
+either\r
+\r
+So I think these patches are good until someone(tm) finds other\r
+issues (if any),\r
+\r
+> Blake\r
+\r
+Tomi\r