Re: [PATCH] configure: really expand libdir_expanded

diff --git a/2e/1ab7e398b747b4bf58a518fd75c0aac6f86c28 b/2e/1ab7e398b747b4bf58a518fd75c0aac6f86c28
new file mode 100644 (file)
index 0000000..37df951
--- /dev/null
+++ b/2e/1ab7e398b747b4bf58a518fd75c0aac6f86c28
@@ -0,0 +1,96 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D3945431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 28 Nov 2012 04:31:24 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id kwyRuLCBZfPR for <notmuch@notmuchmail.org>;\r
+       Wed, 28 Nov 2012 04:31:23 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id B6CA7431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 28 Nov 2012 04:31:23 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 7E53F1000E5;\r
+       Wed, 28 Nov 2012 14:31:21 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] configure: really expand libdir_expanded\r
+In-Reply-To: <1354105552-31297-1-git-send-email-david@tethera.net>\r
+References: <1354105552-31297-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+116~g29fcdb5 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 28 Nov 2012 14:31:21 +0200\r
+Message-ID: <m2ip8pewo6.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 28 Nov 2012 12:31:25 -0000\r
+\r
+On Wed, Nov 28 2012, david@tethera.net wrote:\r
+\r
+> From: David Bremner <bremner@debian.org>\r
+>\r
+> It turns out that if people really use configure in autotools style and pass\r
+> libdir containing '${prefix}/foo' then the ldconfig previously failed.\r
+>\r
+> This uses sed for portability (versus bash parameter expansion with\r
+> substitution) and hopefully a bit more robustness than blindly\r
+> parameter expanding the string.\r
+> ---\r
+\r
+For the record: +1\r
+\r
+Tomi\r
+\r
+\r
+>  configure |    7 ++++++-\r
+>  1 file changed, 6 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/configure b/configure\r
+> index ea8a1ad..460fcfc 100755\r
+> --- a/configure\r
+> +++ b/configure\r
+> @@ -236,7 +236,12 @@ done\r
+>  # Makefile.config file later like most values), because we need to\r
+>  # actually investigate this value compared to the ldconfig_paths value\r
+>  # below.\r
+> -libdir_expanded=${LIBDIR:-${PREFIX}/lib}\r
+> +if [ -z "$LIBDIR" ] ; then\r
+> +    libdir_expanded="${PREFIX}/lib"\r
+> +else\r
+> +    # very non-general variable expansion\r
+> +    libdir_expanded=`echo "$LIBDIR" | sed "s|\\${prefix}|${PREFIX}|g; s|\\$prefix/|${PREFIX}/|; s|//*|/|g"`\r
+> +fi\r
+>  \r
+>  cat <<EOF\r
+>  Welcome to Notmuch, a system for indexing, searching and tagging your email.\r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r