Re: [PATCH 3/3] cli: refactor "notmuch restore" message tagging into a separate function

diff --git a/c8/05d97ea0cf65652d61d4f937f08350d9539b45 b/c8/05d97ea0cf65652d61d4f937f08350d9539b45
new file mode 100644 (file)
index 0000000..47cbed7
--- /dev/null
+++ b/c8/05d97ea0cf65652d61d4f937f08350d9539b45
@@ -0,0 +1,69 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D142B431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 25 Mar 2012 06:33:52 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 6Iu9L3a+Aijc for <notmuch@notmuchmail.org>;\r
+       Sun, 25 Mar 2012 06:33:50 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 4BBBD431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 25 Mar 2012 06:33:50 -0700 (PDT)\r
+Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([142.166.230.117] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.72) (envelope-from <bremner@unb.ca>)\r
+       id 1SBnZs-0007Nw-83; Sun, 25 Mar 2012 10:33:48 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1SBnZm-00075i-Uf; Sun, 25 Mar 2012 10:33:42 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/3] cli: refactor "notmuch restore" message tagging into\r
+       a separate function\r
+In-Reply-To:\r
+ <5adca8d3701d9d01b8cb67e589ce8516d4df9832.1332604895.git.jani@nikula.org>\r
+References: <cover.1332604895.git.jani@nikula.org>\r
+       <5adca8d3701d9d01b8cb67e589ce8516d4df9832.1332604895.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.12 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 25 Mar 2012 10:33:42 -0300\r
+Message-ID: <87bonkztxl.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 25 Mar 2012 13:33:53 -0000\r
+\r
+On Sat, 24 Mar 2012 18:14:37 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> Refactor to make tagging code easier to reuse in the future. No\r
+> functional changes.\r
+\r
+The second two look OK as well.  It isn't obvious to me that in the long\r
+term we want an API using "file_tags" to pass in a string. It reminds me\r
+of the term "stringly typed". Of course, I see why it is this way in an\r
+intial refactor, but maybe something to think about before we start\r
+propagating such an API.\r
+\r
+d\r