Re: [PATCH 0/7] emacs: JSON-based search cleanups

diff --git a/2c/7ed83967855fb5474122f6a1e4b1c6f3bb8be1 b/2c/7ed83967855fb5474122f6a1e4b1c6f3bb8be1
new file mode 100644 (file)
index 0000000..0d64d11
--- /dev/null
+++ b/2c/7ed83967855fb5474122f6a1e4b1c6f3bb8be1
@@ -0,0 +1,107 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C100B431FC3\r
+       for <notmuch@notmuchmail.org>; Fri, 13 Jul 2012 20:28:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id K0GMJRT2ieHY for <notmuch@notmuchmail.org>;\r
+       Fri, 13 Jul 2012 20:28:08 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU\r
+       [18.7.68.37])\r
+       by olra.theworths.org (Postfix) with ESMTP id 71913431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 13 Jul 2012 20:28:08 -0700 (PDT)\r
+X-AuditID: 12074425-b7f9b6d0000008c4-c8-5000e7455cbb\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+       by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 59.6D.02244.547E0005; Fri, 13 Jul 2012 23:28:05 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q6E3S4ux025389; \r
+       Fri, 13 Jul 2012 23:28:05 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6E3S3m3018347\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Fri, 13 Jul 2012 23:28:04 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1Spt1X-0000rp-3K; Fri, 13 Jul 2012 23:28:03 -0400\r
+Date: Fri, 13 Jul 2012 23:28:03 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 0/7] emacs: JSON-based search cleanups\r
+Message-ID: <20120714032744.GE31670@mit.edu>\r
+References: <1342140319-19859-1-git-send-email-amdragon@mit.edu>\r
+       <871ukf8r8q.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <871ukf8r8q.fsf@qmul.ac.uk>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42IRYrdT13V9zhBgcHazssXquTwW12/OZHZg\r
+       8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4Mk6uSC14zFVxqOsuWwPjQY4uRg4OCQETid7Z\r
+       nl2MnECmmMSFe+vZuhi5OIQE9jFKbPzfwQySEBLYwCjxfhIjROIkk0Tb6zYoZwmjxL/Tu9lB\r
+       qlgEVCUW7GtiBbHZBDQktu1fzghiiwjoSNw+tACshllAWuLb72YmEFtYwEpi9dV9LCA2L1DN\r
+       mrd72CC2xUksubUeKi4ocXLmExaIXi2JG/9eMoFcDTJn+T8OkDAn0KoZh4+ArRUVUJGYcnIb\r
+       2wRGoVlIumch6Z6F0L2AkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqRroVebmaJXmpK6SZGcEC7\r
+       qO5gnHBI6RCjAAejEg9voj9DgBBrYllxZe4hRkkOJiVRXobHQCG+pPyUyozE4oz4otKc1OJD\r
+       jBIczEoivOZtQDnelMTKqtSifJiUNAeLkjjvjZSb/kIC6YklqdmpqQWpRTBZGQ4OJQlesWdA\r
+       jYJFqempFWmZOSUIaSYOTpDhPEDDI0FqeIsLEnOLM9Mh8qcYFaXEeQtAEgIgiYzSPLheWMJ5\r
+       xSgO9IowbxVIFQ8wWcF1vwIazAQ0eNbPf/5Ag0sSEVJSDYwHtLwyUk68nbVlaYts3J8DD2Z2\r
+       nah5s/ZQsbtxmPUE03UxP6/dMV/W7CT8z71ubZgdy9Pai+1Xbr/Yvkp36yyVjLzlR8uXX/to\r
+       dqYrUb7vd2l9/Mv6A7XtDHP2q3/9wxrOFOa64NS9KucVYtZykiLuUdIm0cez46XtHmWqFIfu\r
+       zSvVS7lsaKvEUpyRaKjFXFScCACUtiEUEwMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 14 Jul 2012 03:28:10 -0000\r
+\r
+Quoth Mark Walters on Jul 13 at  7:12 pm:\r
+> On Fri, 13 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > This series builds on the JSON-based search series [0] to clean up\r
+> > several other aspects of search-mode.  It removes constraints on the\r
+> > formatting of tags in the result line (you can even leave them out\r
+> > entirely), it recolors lines when tags change, it adds supports for\r
+> > multi-line result formats, and rendering big search buffers should be\r
+> > less quadratic (it might even be linear).  Much of this derives from\r
+> > having a single object representation of a result (the JSON plist) and\r
+> > a simple method for rendering it to the buffer.\r
+> \r
+> Overall this series looks excellent. I have reviewed all the patches\r
+> except patch 4/7 (I will need to work out how macros work to review\r
+> that) and they seem fine modulo the small comments I have made.\r
+> \r
+> One final comment: I couldn't persuade the defcustom search result to\r
+> take a newline symbol to test multiline results. It seems to escape\r
+> entries of \n, and I couldn't enter returns (and ^Q return didn't work\r
+> either).\r
+\r
+C-q C-j worked for me.  Not the most obvious, certainly.\r
+\r
+> It was easy by editing the option in my .emacs file and then seemed to\r
+> work as expected.\r
+> \r
+> Best wishes\r
+> \r
+> Mark\r
+> >\r
+> > [0] 1341870162-17782-1-git-send-email-amdragon@mit.edu\r